jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Guggisberg (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-13) Cleanup org.apache.jackrabbit.mk
Date Thu, 07 Jun 2012 14:32:23 GMT

    [ https://issues.apache.org/jira/browse/OAK-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291032#comment-13291032
] 

Stefan Guggisberg edited comment on OAK-13 at 6/7/12 2:31 PM:
--------------------------------------------------------------

> To finalise this I propose to:
>
> * move {{o.a.j.mk.index}} to {{o.a.j.oak.query.index}}
> * move everything which is required for the query implementation in oak core from {{o.a.j.mk.simpl}}
to {{o.a.j.oak.query}} or an adequate sub-package thereof.
> * move {{o.a.j.mk.wrapper}} to a utility package in oak-mk since this package essentially
contains Microkernel implementations.

the problem is that some classes in the o.a.j.mk.wrapper package have dependencies on o.a.j.mk.simple
code.
if they would only depend on the MicroKernel api i'd suggest to move them to new module (e.g.
oak-mk-commons). 

> * move the classes in {{o.a.j.mk.util}} to util packages in oak-mk, oak-core or oak-commons
as required.
> * move {{o.a.j.mk.MicroKernelFactory}} to oak-mk since this class is concernd with Microkernel
implementations only.

-1, we should try to resolve the MicroKernelFactory issue instead of moving it around. see
[1] for a related discussion.

> * move the Simple implementation in {{o.a.j.mk.simple}} either to an package {{experimental}}
in oak-mk, to an own sub-module oak-experimental or to the sandbox.

-1 for moving it to oak-mk. we had that situation (different implementations in the same module)
before. i'd like to avoid that because it's IMO confusing.

[1]  http://oak.markmail.org/thread/j34cd5m6ti5nwuit
                
      was (Author: stefan@jira):
    > To finalise this I propose to:
>
> * move {{o.a.j.mk.index}} to {{o.a.j.oak.query.index}}
> * move everything which is required for the query implementation in oak core from {{o.a.j.mk.simpl}}
to {{o.a.j.oak.query}} or an adequate sub-package thereof.
> * move {{o.a.j.mk.wrapper}} to a utility package in oak-mk since this package essentially
contains Microkernel implementations.

the problem is that some classes in the o.a.j.mk.wrapper package have dependencies on o.a.j.mk.simple
code.
if they would only depend on the MicroKernel api i'd suggest to move them to new module (e.g.
oak-mk-commons). 

> * move the classes in {{o.a.j.mk.util}} to util packages in oak-mk, oak-core or oak-commons
as required.
> * move {{o.a.j.mk.MicroKernelFactory}} to oak-mk since this class is concernd with Microkernel
implementations only.

-1, we should try to resolve the MicroKernelFactory issue instead of moving it around. see
[1] for a related discussion.

> * move the Simple implementation in {{o.a.j.mk.simple}} either to an package {{experimental}}
in oak-mk, to an own sub-module oak-experimental or to the sandbox.

-1 for moving it to oak-mk. we had that situation (different implementations in the same module)
before. i'd like to avoid that because it's IMO confusing.
                  
> Cleanup org.apache.jackrabbit.mk
> --------------------------------
>
>                 Key: OAK-13
>                 URL: https://issues.apache.org/jira/browse/OAK-13
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core
>            Reporter: angela
>
> imo we should clean up the org.apache.jackrabbit.mk.* packages that are currently
> located in the oak-core module.
> for me it is really hard to destinguish between code that is really part of the
> productive code base for the oak project and code that is purely experimental
> chunk and leftover.
> in order to become familiar with the code that would be helpful for me and
> anybody else that will contribute to the project.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message