Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 75B48CEC1 for ; Wed, 23 May 2012 12:56:28 +0000 (UTC) Received: (qmail 94830 invoked by uid 500); 23 May 2012 12:56:28 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 94802 invoked by uid 500); 23 May 2012 12:56:28 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 94793 invoked by uid 99); 23 May 2012 12:56:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 May 2012 12:56:28 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com designates 209.85.212.170 as permitted sender) Received: from [209.85.212.170] (HELO mail-wi0-f170.google.com) (209.85.212.170) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 May 2012 12:56:23 +0000 Received: by wibhm6 with SMTP id hm6so4591730wib.1 for ; Wed, 23 May 2012 05:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; bh=IJqCq7HSlJWGZYWYs99vnj2vpzqGD+60Z9QkOFGMuqE=; b=hUBG7kdYogLefGDmzEF9BNM7c+Y+p+yV3BQkfkbeaYtmBOwgqewHvdT61QTvdy2jff hvsStHqq8WN9/Ml9YCzIHe4sGi+yre2cn1QeVDnj42hkYmYBb46mNCyQhmeKbmvyGtFG byR7NvHNmOTfMyGovGml8UXz3k4t/5xbIn2TcPSGx9Z8ibkX3Qui/CZPx+d2nh966R9i 1sUojRkW6wcq5h+YbMlLJt9BSh2pzzWRkiuPvUgwVHXB4lwzkbCbTWWBCwf6LNAB3JD9 07hJltWKw/YqEhwV76WvmIZk8etotQUT8asEe7tw8xNQKWbNh9UXEpkkWkxcBYVy3BjT QROQ== Received: by 10.180.88.194 with SMTP id bi2mr45709890wib.20.1337777762174; Wed, 23 May 2012 05:56:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.180.85.167 with HTTP; Wed, 23 May 2012 05:55:41 -0700 (PDT) In-Reply-To: <4FBCD4D2.3030600@gmx.de> References: <20120523120610.4ECC023889BF@eris.apache.org> <4FBCD4D2.3030600@gmx.de> From: Jukka Zitting Date: Wed, 23 May 2012 14:55:41 +0200 Message-ID: Subject: Re: findbugs To: oak-dev@jackrabbit.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org Hi, On Wed, May 23, 2012 at 2:15 PM, Julian Reschke wro= te: > ...with the change below, findbugs can be run in oak-jcr with > > =A0mvn findbugs:findbugs > > ...leaving an XML file in ./target. There's also > > =A0mvn findbugs:gui > > for those who prefer point-and-click. Nice! Do we really need a SNAPSHOT version of the FindBugs plugin, or is the latest release good enough? > Should we add this globally? Sounds like a useful thing to have, so +1 to adding it to the parent POM. Did you already figure out a way for us to integrate FindBugs checks to to the test phase of the build so we could fail the build if explicitly enabled FindBugs checks fail? BR, Jukka Zitting