Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Date: Thu, 3 May 2012 22:08:51 +0000 (UTC)
From: =?utf-8?Q?Michael_D=C3=BCrig_=28JIRA=29?= <jira@apache.org>
To: oak-dev@jackrabbit.apache.org
Message-ID: 
 <606133507.24219.1336082931120.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1270434046.22129.1336058209368.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (OAK-84) Delegates for Session, Node, Property
 and Item
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/OAK-84?page=3Dcom.atlassian.jir=
a.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13267866=
#comment-13267866 ]=20

Michael D=C3=BCrig commented on OAK-84:
----------------------------------

bq. Item.getDepth() is already implemented in the AbstractItem class of jcr=
-commons.=20

Revision 1333652 incorporates the patch.

We should now start using the *Delegate classes internally instead of the r=
espective *Impl classes since one can always go from the delegate to the im=
pl. but not necessarily vice versa.=20
               =20
> Delegates for Session, Node, Property and Item
> ----------------------------------------------
>
>                 Key: OAK-84
>                 URL: https://issues.apache.org/jira/browse/OAK-84
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Michael D=C3=BCrig
>         Attachments: 0001-OAK-84-Delegates-for-Session-Node-Property-and-=
Item.patch
>
>
> Instead of passing around Nodes internally and casting them down to NodeI=
mpl we should use the fa=C3=A7ade pattern and delegate from NodeImpl back t=
o an implementation class which is used internally. This also avoids the pr=
oblem of API clients accessing stuff they shouldn't by casting to the imple=
mentation.=20
> Some initial work has been done already. What's left to do it:=20
> * Push down as much as possible from ItemImpl, NodeImpl and PropertyImpl =
to the respective delegate classes
> * Introduce the same pattern for SessionImpl and do away with SessionCont=
ext.=20

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira