Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BAD5916D for ; Mon, 7 May 2012 16:10:33 +0000 (UTC) Received: (qmail 85646 invoked by uid 500); 7 May 2012 16:10:33 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 85597 invoked by uid 500); 7 May 2012 16:10:33 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 85588 invoked by uid 99); 7 May 2012 16:10:33 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 May 2012 16:10:33 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of julian.reschke@gmx.de designates 213.165.64.22 as permitted sender) Received: from [213.165.64.22] (HELO mailout-de.gmx.net) (213.165.64.22) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 07 May 2012 16:10:24 +0000 Received: (qmail invoked by alias); 07 May 2012 16:10:02 -0000 Received: from mail.greenbytes.de (EHLO [192.168.1.140]) [217.91.35.233] by mail.gmx.net (mp010) with SMTP; 07 May 2012 18:10:02 +0200 X-Authenticated: #1915285 X-Provags-ID: V01U2FsdGVkX19JkbE2AalJYaHxbQJaRYxKKjt6Fkrg2Xe8/DfJLJ xT8RJNdaXRxfpp Message-ID: <4FA7F3D6.9030803@gmx.de> Date: Mon, 07 May 2012 18:09:58 +0200 From: Julian Reschke User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: oak-dev@jackrabbit.apache.org CC: =?UTF-8?B?TWljaGFlbCBEw7xyaWc=?= Subject: Re: occasional TCK test failure References: <20120504153221.19A26238890B@eris.apache.org> <4FA50241.3010208@gmx.de> <4FA52AF9.8040809@apache.org> In-Reply-To: <4FA52AF9.8040809@apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Y-GMX-Trusted: 0 On 2012-05-05 15:28, Michael Dürig wrote: > > > On 5.5.12 11:34, Julian Reschke wrote: >> Hi there, >> >> occasionally I get a test failure because the TCK discovers a node that >> lacks a primary type. >> >> As far as I recall, it's either /jcr:system or >> /jcr:system/jcr:namespaces (of course right now it doesn't occur). >> >> With the change below I tried to make sure the type is set, but maybe >> I'm doing something wrong? >> >> if (create) { >> system = tree.addChild("jcr:system"); >> + system.setProperty("jcr:primaryType", >> this.session.getCoreValueFactory().createValue("rep:system", >> PropertyType.NAME)); >> } else { > > This looks good to me. There are two things we should do further down > ... FWIW I haven't seen the failure again. > ... Best regards, Julian