jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig <mdue...@apache.org>
Subject Re: nullability annotations - https://issues.apache.org/jira/browse/OAK-37
Date Wed, 23 May 2012 20:53:39 GMT


On 23.5.12 21:22, Julian Reschke wrote:
> On 2012-05-23 18:43, Michael Dürig wrote:
>>
>> Hi,
>>
>> IntelliJ gives me the warning
>>
>> "Not annotated method overrides method annotated with @NotNull"
>>
>> whenever a method is not annotated with @NotNull and the method it
>> overrides is annotated with @NotNull.
>>
>> Should we add annotations in all those places? Or should we ignore the
>> warning?
>> ...
>
> Findbugs inherits the annotation and does apply it.

Ok.

>
> If adding it to the implementation avoids warning noise in IntelliJ,
> let's do that.

I just disabled this warning in IntelliJ globally. It seems IntelliJ 
also inherits the annotations so there is no point in having the warning 
or spaming the code with extra annotations.

Michael

>
> Best regards, Julian


Mime
View raw message