jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OAK-37) Use nullability annotation to enforce/document API contract
Date Wed, 16 May 2012 15:35:02 GMT

     [ https://issues.apache.org/jira/browse/OAK-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Julian Reschke updated OAK-37:
------------------------------

    Attachment: nullability.patch

Minimal demonstration, showing how to embed the annotations.

Note:

- cross project checking with the FindBugs plugin in Eclipse indeed works

- FindBugs report:
Possible null pointer dereference in org.apache.jackrabbit.oak.jcr.security.user.UserManagerImpl.removeInternalProperty(Node,
String) due to return value of called method	UserManagerImpl.java	/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/security/user
line 352	FindBugs Problem (Troubling)

I believe this is something we should do; running FindBugs from the actual Maven build would
be the next step
                
> Use nullability annotation to enforce/document API contract
> -----------------------------------------------------------
>
>                 Key: OAK-37
>                 URL: https://issues.apache.org/jira/browse/OAK-37
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, jcr, mk
>            Reporter: Michael Dürig
>            Assignee: Julian Reschke
>         Attachments: nullability.patch
>
>
> In a discussion about exception handling on the dev list [1] Julian brough up the idea
of using nullability annotations in APIs. I think we should decide on which one to use and
start using them whereever apropriate. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message