jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OAK-89) Improve exception handling
Date Wed, 09 May 2012 10:55:53 GMT

     [ https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jukka Zitting updated OAK-89:
-----------------------------

    Attachment: OAK-89.patch

See the attached patch. It's close to half the size of the earlier patches and correctly handles
throwing {{PathNotFound}}-, {{ValueFormat}}- and {{RepositoryExceptions}} where appropriate
or simply returning {{false}} where an exception is not needed.

Note especially the {{SessionDelegate.getOakPathOr...}} methods that encode some of the different
outcomes of a failed name or path mapping.

A breakdown of the patch is also available at https://github.com/jukka/jackrabbit-oak/compare/trunk...OAK-89

bq. ... nullability annotations ...

Sounds like a good idea to me.
                
> Improve exception handling
> --------------------------
>
>                 Key: OAK-89
>                 URL: https://issues.apache.org/jira/browse/OAK-89
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, jcr
>    Affects Versions: 0.2.1
>            Reporter: Michael Dürig
>         Attachments: OAK-89-2.patch, OAK-89.patch, OAK-89.patch
>
>
> As discusses on the @oak-dev list [1] we need to improve the way exceptions are thrown
and handled. 
> I suggest to create a OakException which extends from RuntimeException and encapsulate
a RepositoryException into it. These exceptions can then be handled where appropriate. We
can the later turn this into a more sophisticated mechanism where the OakException is mapped
to a corresponding RepositoryException by an injected mapping (see Jukka's proposal in the
discussion).
> [1] http://markmail.org/message/t5czrpkvyamn7sym

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message