Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 728F497BF for ; Fri, 13 Apr 2012 20:55:38 +0000 (UTC) Received: (qmail 28863 invoked by uid 500); 13 Apr 2012 20:55:38 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 28836 invoked by uid 500); 13 Apr 2012 20:55:38 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 28826 invoked by uid 99); 13 Apr 2012 20:55:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Apr 2012 20:55:38 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Apr 2012 20:55:37 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 506773699BB for ; Fri, 13 Apr 2012 20:55:16 +0000 (UTC) Date: Fri, 13 Apr 2012 20:55:16 +0000 (UTC) From: "Jukka Zitting (Commented) (JIRA)" To: oak-dev@jackrabbit.apache.org Message-ID: <470679483.23586.1334350516331.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <2102121911.22478.1334332218445.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (OAK-65) Naming of NodeState and related classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OAK-65?page=3Dcom.atlassian.jir= a.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13253735= #comment-13253735 ]=20 Jukka Zitting commented on OAK-65: ---------------------------------- I'm not too tied to the naming, and as mentioned, the {{...State}} names do= come with quite a bit of baggage from jr2. Just pointing out that this was= already discussed and a rough consensus was reached (though in the context= of the MK). Anyway, I think we can and should revisit naming as part of a = broader Oak API design discussion (like the one Angela and you were already= starting). =20 > Naming of NodeState and related classes > --------------------------------------- > > Key: OAK-65 > URL: https://issues.apache.org/jira/browse/OAK-65 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, mk > Reporter: Michael D=C3=BCrig > > As discussed here [1] we should rethink the nameing of the NodeState and = related classes.=20 > I suggest the following renaming: > NodeState -> NodeData > PropertyState -> PropertyData > TransientNodeState -> NodeState > KernelNodeState -> KernelNodeData > My reasoning: the current NodeState and PropertyState classes are immutab= le (and thus > represent pure values i.e. data). The word state implies mutability > (after all OOP is about mutation of state all over) so renaming > TransientNodeState to NodeState should make sense. Also the oak API will > be more publicly visible than the lower level MK API. So having catchy > names there is a plus.=20 > http://markmail.org/thread/xi5dgjljduc7y7eq -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira