jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig <mdue...@apache.org>
Subject Re: oak api
Date Tue, 10 Apr 2012 16:58:49 GMT


On 10.4.12 17:46, Jukka Zitting wrote:
> Hi,
>
> On Tue, Apr 10, 2012 at 5:49 PM, Michael Dürig<mduerig@apache.org>  wrote:
>> Since these are needed in oak-mk, oak-core and oak-jcr we need either need
>> to duplicate them or factor them out into separate module(s).
>
> Let's just duplicate them and see how much they diverge over time. It
> seems like we already have competing demands on things like value
> handling so even though I didn't earlier like the idea of duplication
> I guess it's the best approach for now.
>
> To implement this, I'd leave the existing interfaces in oak-mk and
> create copies under .oak.api in oak-core. The Scalar interface and the
> corresponding implementation class are probably not needed in oak-mk,
> so I assume they can be moved entirely to oak-core.

Ok ack.

>
> I can take care of this later tonight unless anyone beats me to it.

That'd be great. Thanks.

>
> PS. I much prefer the earlier NodeStateBuilder name to
> NodeStateEditor, since it emphasizes that we're building new
> NodeStates instead of editing existing ones. According to the API
> contract a NodeState should be immutable and thus not editable.
>

Feel free to rename. I was taking more the view of the user here who 
doesn't care about the underlying implementation and for whom the end 
result is pretty much the same. But emphasising the immutable nature 
definitely makes sense.

Michael

Mime
View raw message