jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-48) MicroKernel.getNodes() should return null for not existing nodes instead of throwing an exception
Date Thu, 05 Apr 2012 13:49:27 GMT

    [ https://issues.apache.org/jira/browse/OAK-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247220#comment-13247220
] 

Thomas Mueller commented on OAK-48:
-----------------------------------

+1 return null if the node doesn't exist

In addition to what Jukka wrote, this would avoid potential concurrency problems in case 
the MicroKernel implementation doesn't or only halfheartedly supports the concept of revisions
(the node could be deleted after nodeExists() and getNodes()).

In theory, we could remove nodeExists() from the API
(testing for existence could be achieved using a special variant of getNodes()).

                
> MicroKernel.getNodes() should return null for not existing nodes instead of throwing
an exception
> -------------------------------------------------------------------------------------------------
>
>                 Key: OAK-48
>                 URL: https://issues.apache.org/jira/browse/OAK-48
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: mk
>            Reporter: Michael Dürig
>
> As discussed on the list [1, 2] exceptions should only be used for exceptional cases.
Requesting a not existing node through Microkernel.getNodes() should therefore rather return
null instead of throwing an exception.
> [1] http://markmail.org/thread/agibgcdjv756m53u
> [2] http://markmail.org/message/gfbmogwr6mrhe2pm

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message