jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-55) Provide reasonable way to set property on NodeStateEditor
Date Tue, 10 Apr 2012 13:17:19 GMT

    [ https://issues.apache.org/jira/browse/OAK-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250633#comment-13250633
] 

angela commented on OAK-55:
---------------------------

i will take care of that
                
> Provide reasonable way to set property on NodeStateEditor
> ---------------------------------------------------------
>
>                 Key: OAK-55
>                 URL: https://issues.apache.org/jira/browse/OAK-55
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: angela
>            Assignee: angela
>
> currently properties are add/modified on the NodeStateEditor using:     void setProperty(PropertyState
state);
> the consequence of that is that every single usage of that method needs to know the details
> of how to create a property state. IMO that's really bad practice and should be refactored.
> i would suggest to change it to something like 
> - setProperty(String name, Scalar value)
> - setProperty(String name, List<Scalar> values)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message