From oak-dev-return-100-apmail-jackrabbit-oak-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Mon Mar 12 16:57:59 2012 Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B28179C49 for ; Mon, 12 Mar 2012 16:57:59 +0000 (UTC) Received: (qmail 31420 invoked by uid 500); 12 Mar 2012 16:57:59 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 31380 invoked by uid 500); 12 Mar 2012 16:57:59 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 31360 invoked by uid 99); 12 Mar 2012 16:57:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2012 16:57:59 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2012 16:57:58 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A2EC81C273 for ; Mon, 12 Mar 2012 16:57:38 +0000 (UTC) Date: Mon, 12 Mar 2012 16:57:38 +0000 (UTC) From: "Jukka Zitting (Commented) (JIRA)" To: oak-dev@jackrabbit.apache.org Message-ID: <711350122.3462.1331571458668.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <815300821.3390.1331570379805.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (OAK-10) Impedance mismatch between signatures of NodeState#getChildeNodeEntries and MicroKernel#getNodes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OAK-10?page=3Dcom.atlassian.jir= a.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13227683= #comment-13227683 ]=20 Jukka Zitting commented on OAK-10: ---------------------------------- I set the parameter type to long for consistency with the offset parameter,= but as you said, it could just as well be an int. I'm fine also with renam= ing the parameter. =20 > Impedance mismatch between signatures of NodeState#getChildeNodeEntries a= nd MicroKernel#getNodes > -------------------------------------------------------------------------= ----------------------- > > Key: OAK-10 > URL: https://issues.apache.org/jira/browse/OAK-10 > Project: Jackrabbit Oak > Issue Type: Improvement > Reporter: Michael D=C3=BCrig > Fix For: 0.1 > > > NodeState#getChildeNodeEntries uses long for its lenght parameter while M= icroKernel#getNodes uses int. In order to implement the NodeState interface= on top of the Microkernel, it would be favourable if the type would be the= same.=20 > I suggest we change it to int for both methods since a length bigger than= Integer.MAX_VALUE is not realistic anyway. On a related note, I'd rename t= he parameter from length to count.=20 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira