jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (Commented) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-29) Simplify SessionContext
Date Wed, 21 Mar 2012 12:59:44 GMT

    [ https://issues.apache.org/jira/browse/OAK-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234327#comment-13234327

Michael Dürig commented on OAK-29:

The original intention was to have a generic session context which allows for different session
implementations and avoids casting. I added the Context interface in SessionImpl basically
as an alias for the unwieldy SessionContext<SessionImpl>. This could be easily undone.
Patch follows. 

The need for different session implementations came into the picture when we where discussing
light weight read only sessions which are always on the head revision. These could be useful
for example for observation listeners. 

If we don't have a need for different session implementations we can easily scrap the SessionContext
interface and make it into a SessionContext class.

Furthermore I'm generally in favour of Jukka's proposal but have yet to see a more worked
out concept of that.
> Simplify SessionContext
> -----------------------
>                 Key: OAK-29
>                 URL: https://issues.apache.org/jira/browse/OAK-29
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: angela
> the current way to implement a SessionContext is IMO over-engineered.
> a simple thing like a container used to pass around stuff associated
> with a session shouldn't cause headache such as the current implementation
> does using a derived interface and the original not even being used.
> while we are at this:
> jukka once suggested to use an adapter class in order not to expose
> the sessionImpl altogether on the JCR level. that might be a next step to go.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message