jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig <mdue...@apache.org>
Subject Re: svn commit: r1305860 - in /jackrabbit/oak/trunk: oak-core/ oak-core/src/main/java/org/apache/jackrabbit/oak/api/ oak-core/src/main/java/org/apache/jackrabbit/oak/api/impl/ oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/ oak-jcr/src/test/java/o...
Date Wed, 28 Mar 2012 09:13:38 GMT


On 28.3.12 7:50, Angela Schreiber wrote:
>>> +
>>> + /**
>>> + * Returns the current revision the associated session is operating on.
>>> + * Upon creation of a given {@code SessionInfo} instance the initial
>>> + * revision is always set to the head revision. Upon successful commit
>>> + * of changes the revision is reset to match the latest state.
>>> + *
>>> + * TODO: define how the desired initial revision is passed to the
>>> oak-api / mk
>>> + * TODO: define how and when the revision is updated (would a
>>> setRevision required? and who would use it?)
>>
>> I wouldn't add support for setting the revision through the API. This
>> should only happen as a result of some higher level API like save() and
>> refresh() and possibly others.
>
> ok. glad to hear... that was my impression as well, but i would
> be open in case there was some compelling reason for having it.

So would I. But having it there from begin with will lead people to do 
all sorts of "funny things" with.

> regarding defining the revision
> upon initial login, that could be achieved by an attribute on the
> credentials.... but that's definitely not a first prio issue to solve.

That's my thinking too. So let's just keep this in the back of our minds 
(aka todos in the code).

Michael

Mime
View raw message