jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-29) Simplify SessionContext
Date Wed, 21 Mar 2012 14:17:38 GMT

    [ https://issues.apache.org/jira/browse/OAK-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234371#comment-13234371
] 

angela commented on OAK-29:
---------------------------

the patch looks fine to me.
basically in wonder if we would ever have the need for another session-context.
the main usage of it is to grant access to SessionImpl and other internal stuff
in order to prevent passing around the SessionImpl object.  
                
> Simplify SessionContext
> -----------------------
>
>                 Key: OAK-29
>                 URL: https://issues.apache.org/jira/browse/OAK-29
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: angela
>         Attachments: OAK-29.patch
>
>
> the current way to implement a SessionContext is IMO over-engineered.
> a simple thing like a container used to pass around stuff associated
> with a session shouldn't cause headache such as the current implementation
> does using a derived interface and the original not even being used.
> while we are at this:
> jukka once suggested to use an adapter class in order not to expose
> the sessionImpl altogether on the JCR level. that might be a next step to go.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message