Return-Path: X-Original-To: apmail-jackrabbit-oak-commits-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1FD6E10D72 for ; Wed, 4 Dec 2013 11:57:45 +0000 (UTC) Received: (qmail 25172 invoked by uid 500); 4 Dec 2013 11:57:45 -0000 Delivered-To: apmail-jackrabbit-oak-commits-archive@jackrabbit.apache.org Received: (qmail 25130 invoked by uid 500); 4 Dec 2013 11:57:44 -0000 Mailing-List: contact oak-commits-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-commits@jackrabbit.apache.org Received: (qmail 25110 invoked by uid 99); 4 Dec 2013 11:57:42 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Dec 2013 11:57:42 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Dec 2013 11:57:39 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id B275E23889D5; Wed, 4 Dec 2013 11:57:18 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1547773 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/DefaultSyncHandler.java Date: Wed, 04 Dec 2013 11:57:18 -0000 To: oak-commits@jackrabbit.apache.org From: angela@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20131204115718.B275E23889D5@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: angela Date: Wed Dec 4 11:57:18 2013 New Revision: 1547773 URL: http://svn.apache.org/r1547773 Log: OAK-516 : Create LdapLoginModule based on ExternalLoginModule - add comment and todos Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/DefaultSyncHandler.java Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/DefaultSyncHandler.java URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/DefaultSyncHandler.java?rev=1547773&r1=1547772&r2=1547773&view=diff ============================================================================== --- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/DefaultSyncHandler.java (original) +++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/DefaultSyncHandler.java Wed Dec 4 11:57:18 2013 @@ -111,6 +111,8 @@ public class DefaultSyncHandler implemen @CheckForNull private User createUser(ExternalUser externalUser) throws RepositoryException, SyncException { if (mode.contains(SyncMode.MODE_CREATE_USER)) { + // sync user without password. + // TODO: what intermediate path to use for the user creation? User user = userManager.createUser(externalUser.getId(), null, externalUser.getPrincipal(), null); syncAuthorizable(externalUser, user); return user; @@ -122,6 +124,7 @@ public class DefaultSyncHandler implemen @CheckForNull private Group createGroup(ExternalGroup externalGroup) throws RepositoryException, SyncException { if (mode.contains(SyncMode.MODE_CREATE_GROUPS)) { + // TODO: what intermediate path to use for the group creation? Group group = userManager.createGroup(externalGroup.getId(), externalGroup.getPrincipal(), null); syncAuthorizable(externalGroup, group); return group;