jackrabbit-oak-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ang...@apache.org
Subject svn commit: r1547773 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/DefaultSyncHandler.java
Date Wed, 04 Dec 2013 11:57:18 GMT
Author: angela
Date: Wed Dec  4 11:57:18 2013
New Revision: 1547773

URL: http://svn.apache.org/r1547773
Log:
OAK-516 : Create LdapLoginModule based on ExternalLoginModule

- add comment and todos

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/DefaultSyncHandler.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/DefaultSyncHandler.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/DefaultSyncHandler.java?rev=1547773&r1=1547772&r2=1547773&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/DefaultSyncHandler.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/DefaultSyncHandler.java
Wed Dec  4 11:57:18 2013
@@ -111,6 +111,8 @@ public class DefaultSyncHandler implemen
     @CheckForNull
     private User createUser(ExternalUser externalUser) throws RepositoryException, SyncException
{
         if (mode.contains(SyncMode.MODE_CREATE_USER)) {
+            // sync user without password.
+            // TODO: what intermediate path to use for the user creation?
             User user = userManager.createUser(externalUser.getId(), null, externalUser.getPrincipal(),
null);
             syncAuthorizable(externalUser, user);
             return user;
@@ -122,6 +124,7 @@ public class DefaultSyncHandler implemen
     @CheckForNull
     private Group createGroup(ExternalGroup externalGroup) throws RepositoryException, SyncException
{
         if (mode.contains(SyncMode.MODE_CREATE_GROUPS)) {
+            // TODO: what intermediate path to use for the group creation?
             Group group = userManager.createGroup(externalGroup.getId(), externalGroup.getPrincipal(),
null);
             syncAuthorizable(externalGroup, group);
             return group;



Mime
View raw message