Return-Path: 
 <oak-commits-return-4296-apmail-jackrabbit-oak-commits-archive=jackrabbit.apache.org@jackrabbit.apache.org>
X-Original-To: apmail-jackrabbit-oak-commits-archive@minotaur.apache.org
Delivered-To: apmail-jackrabbit-oak-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E9E7CCDA4
	for <apmail-jackrabbit-oak-commits-archive@minotaur.apache.org>;
 Tue, 23 Jul 2013 12:06:06 +0000 (UTC)
Received: (qmail 48991 invoked by uid 500); 23 Jul 2013 12:06:06 -0000
Delivered-To: apmail-jackrabbit-oak-commits-archive@jackrabbit.apache.org
Received: (qmail 48963 invoked by uid 500); 23 Jul 2013 12:06:06 -0000
Mailing-List: contact oak-commits-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:oak-commits-help@jackrabbit.apache.org>
List-Unsubscribe: <mailto:oak-commits-unsubscribe@jackrabbit.apache.org>
List-Post: <mailto:oak-commits@jackrabbit.apache.org>
List-Id: <oak-commits.jackrabbit.apache.org>
Reply-To: oak-dev@jackrabbit.apache.org
Delivered-To: mailing list oak-commits@jackrabbit.apache.org
Received: (qmail 48941 invoked by uid 99); 23 Jul 2013 12:06:05 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jul 2013 12:06:05 +0000
X-ASF-Spam-Status: No, hits=-0.7 required=5.0
	tests=RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of chetan.mehrotra@gmail.com
 designates 209.85.219.53 as permitted sender)
Received: from [209.85.219.53] (HELO mail-oa0-f53.google.com) (209.85.219.53)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jul 2013 12:05:58 +0000
Received: by mail-oa0-f53.google.com with SMTP id k14so10881914oag.40
        for <multiple recipients>; Tue, 23 Jul 2013 05:05:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=53LzyocbizW7rqUefjzKHFll1FIbZdnvOy9oWNIg95c=;
        b=vqFQaXQvEkCUbths5tE9j5skDGPQYfsOP/WtsJAaYcS+xjru/hT+VLsDDuECXEXJM3
         06Dwgf5VfmKVtcrZQFZWuQub81tVp8psxFOvtDscmzV0la2CzA7Gc3sG5P1+yeiLVNkg
         tzhkhm6loRiUiP3x8TMu/Z+U4oo3Df3BSCoXjnBKnErboYK1xpscljtCu3JKjwvnqk/p
         Hu2P+oSCP3B9yA7LruigyAYtqdCF0nn7JULvWhf+2HOB3t74FtLdz8Cc/zLWOWmg53In
         siNz/x75SsFROb/ta2WvUkJer/D1xO5Xna0MKiv+0p1AwwWaTPhPMgp4anrdlJHqTtcK
         /4lw==
MIME-Version: 1.0
X-Received: by 10.182.18.40 with SMTP id t8mr24858694obd.85.1374581137690;
 Tue, 23 Jul 2013 05:05:37 -0700 (PDT)
Received: by 10.60.6.99 with HTTP; Tue, 23 Jul 2013 05:05:37 -0700 (PDT)
In-Reply-To: <20130723114547.B8B5E2388993@eris.apache.org>
References: <20130723114547.B8B5E2388993@eris.apache.org>
Date: Tue, 23 Jul 2013 17:35:37 +0530
Message-ID: 
 <CAHCW-mky4aaK7xLkfTpYjFLwsqA-0s-008+1YGCuxCeVRyWKDA@mail.gmail.com>
Subject: Re: svn commit: r1505988 - in /jackrabbit/oak/trunk:
 oak-core/src/main/java/org/apache/jackrabbit/oak/core/
 oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/
 oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/
 oak-core/src/main/java/org/...
From: Chetan Mehrotra <chetan.mehrotra@gmail.com>
To: oak-dev@jackrabbit.apache.org
Cc: oak-commits@jackrabbit.apache.org
Content-Type: text/plain; charset=ISO-8859-1
X-Virus-Checked: Checked by ClamAV on apache.org

Should the synchronization be done on "this" or some other object
which is common across branch instances as there can be multiple
instances of the branch

On Tue, Jul 23, 2013 at 5:15 PM,  <mduerig@apache.org> wrote:
> +        synchronized (this) {
> +            rebase();
> +            NodeState toCommit = checkNotNull(hook).processCommit(base, head);
> +            NodeState oldRoot = head;
> +            head = toCommit;



Chetan Mehrotra