Return-Path: X-Original-To: apmail-jackrabbit-oak-commits-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ACD6D10176 for ; Wed, 17 Jul 2013 15:10:42 +0000 (UTC) Received: (qmail 72956 invoked by uid 500); 17 Jul 2013 15:10:42 -0000 Delivered-To: apmail-jackrabbit-oak-commits-archive@jackrabbit.apache.org Received: (qmail 72938 invoked by uid 500); 17 Jul 2013 15:10:42 -0000 Mailing-List: contact oak-commits-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-commits@jackrabbit.apache.org Received: (qmail 72929 invoked by uid 99); 17 Jul 2013 15:10:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jul 2013 15:10:42 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jul 2013 15:10:39 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id B01A12388860; Wed, 17 Jul 2013 15:10:17 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1504167 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MemoryDocumentStore.java Date: Wed, 17 Jul 2013 15:10:17 -0000 To: oak-commits@jackrabbit.apache.org From: thomasm@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20130717151017.B01A12388860@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: thomasm Date: Wed Jul 17 15:10:17 2013 New Revision: 1504167 URL: http://svn.apache.org/r1504167 Log: OAK-825 Small MongoMK performance improvement Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MemoryDocumentStore.java Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MemoryDocumentStore.java URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MemoryDocumentStore.java?rev=1504167&r1=1504166&r2=1504167&view=diff ============================================================================== --- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MemoryDocumentStore.java (original) +++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MemoryDocumentStore.java Wed Jul 17 15:10:17 2013 @@ -221,7 +221,6 @@ public class MemoryDocumentStore impleme public static void applyChanges(Map target, UpdateOp update) { for (Entry e : update.changes.entrySet()) { String k = e.getKey(); - String[] kv = k.split("\\."); Operation op = e.getValue(); switch (op.type) { case SET: { @@ -238,6 +237,7 @@ public class MemoryDocumentStore impleme break; } case SET_MAP_ENTRY: { + String[] kv = splitInTwo(k, '.'); Object old = target.get(kv[0]); @SuppressWarnings("unchecked") Map m = (Map) old; @@ -249,6 +249,7 @@ public class MemoryDocumentStore impleme break; } case REMOVE_MAP_ENTRY: { + String[] kv = splitInTwo(k, '.'); Object old = target.get(kv[0]); @SuppressWarnings("unchecked") Map m = (Map) old; @@ -258,6 +259,7 @@ public class MemoryDocumentStore impleme break; } case SET_MAP: { + String[] kv = splitInTwo(k, '.'); Object old = target.get(kv[0]); @SuppressWarnings("unchecked") Map m = (Map) old; @@ -274,6 +276,14 @@ public class MemoryDocumentStore impleme } } } + + private static String[] splitInTwo(String s, char separator) { + int index = s.indexOf(separator); + if (index < 0) { + return new String[] { s }; + } + return new String[] { s.substring(0, index), s.substring(index + 1) }; + } @Override public boolean create(Collection collection, List updateOps) {