jackrabbit-oak-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thom...@apache.org
Subject svn commit: r1503180 - /jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/nodetype/NodeTypeIndexTest.java
Date Mon, 15 Jul 2013 11:26:46 GMT
Author: thomasm
Date: Mon Jul 15 11:26:46 2013
New Revision: 1503180

URL: http://svn.apache.org/r1503180
Log:
OAK-98 Make methods static if possible

Modified:
    jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/nodetype/NodeTypeIndexTest.java

Modified: jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/nodetype/NodeTypeIndexTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/nodetype/NodeTypeIndexTest.java?rev=1503180&r1=1503179&r2=1503180&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/nodetype/NodeTypeIndexTest.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/nodetype/NodeTypeIndexTest.java
Mon Jul 15 11:26:46 2013
@@ -72,7 +72,9 @@ public class NodeTypeIndexTest {
         NodeStoreBranch branch = store.branch();
         NodeBuilder root = branch.getHead().builder();
 
-        root.getChildNode("rep:security").remove(); // interferes with tests
+        // remove "rep:security" as it interferes with tests
+        root.getChildNode("rep:security").remove(); 
+        
         addFolder(root, "folder-1");
         addFolder(root, "folder-2");
         addFile(root, "file-1");
@@ -106,7 +108,7 @@ public class NodeTypeIndexTest {
         return new FilterImpl(selector, "SELECT * FROM [" + nodeTypeName + "]");
     }
 
-    private void checkCursor(Cursor cursor, String... matches) {
+    private static void checkCursor(Cursor cursor, String... matches) {
         // make sure the index is actually used
         // and does not traverse
         assertEquals(Cursors.class.getName() + "$PathCursor",
@@ -120,7 +122,7 @@ public class NodeTypeIndexTest {
         assertEquals(expected, actual);
     }
 
-    private NodeBuilder addFolder(NodeBuilder node, String name) {
+    private static NodeBuilder addFolder(NodeBuilder node, String name) {
         return addChild(node, name, JcrConstants.NT_FOLDER);
     }
 
@@ -135,8 +137,9 @@ public class NodeTypeIndexTest {
         return file;
     }
 
-    private NodeBuilder addChild(NodeBuilder node, String name, String nodeType) {
+    private static NodeBuilder addChild(NodeBuilder node, String name, String nodeType) {
         return node.child(name).setProperty(
                 JcrConstants.JCR_PRIMARYTYPE, nodeType, Type.NAME);
     }
+    
 }



Mime
View raw message