jackrabbit-oak-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mdue...@apache.org
Subject svn commit: r1485748 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/TreeImpl.java
Date Thu, 23 May 2013 14:58:50 GMT
Author: mduerig
Date: Thu May 23 14:58:50 2013
New Revision: 1485748

URL: http://svn.apache.org/r1485748
Log:
OAK-842: Incorrect interaction of orderable child nodes with access control
add issue reference

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/TreeImpl.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/TreeImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/TreeImpl.java?rev=1485748&r1=1485747&r2=1485748&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/TreeImpl.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/TreeImpl.java
Thu May 23 14:58:50 2013
@@ -241,6 +241,7 @@ public class TreeImpl implements Tree {
         if (parent != null && parent.hasChild(name)) {
             nodeBuilder.remove();
             if (parent.hasOrderableChildren()) {
+                // FIXME (OAK-842) child order not updated when parent is not accessible
                 parent.nodeBuilder.setProperty(
                         MemoryPropertyBuilder.copy(STRING, parent.nodeBuilder.getProperty(OAK_CHILD_ORDER))
                                 .removeValue(name)
@@ -523,6 +524,7 @@ public class TreeImpl implements Tree {
      * @return the ordered child names.
      */
     private Iterable<String> getOrderedChildNames() {
+        // FIXME (OAK-842) take access control restriction into consideration
         assert hasOrderableChildren();
         return new Iterable<String>() {
             @Override



Mime
View raw message