jackrabbit-oak-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ang...@apache.org
Subject svn commit: r1421925 - in /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak: security/user/ spi/security/user/ spi/security/user/action/
Date Fri, 14 Dec 2012 15:19:22 GMT
Author: angela
Date: Fri Dec 14 15:19:17 2012
New Revision: 1421925

URL: http://svn.apache.org/viewvc?rev=1421925&view=rev
Log:
OAK-50 : Implement User Management (WIP)

- add JIRA subtask references with the individual TODOs and FIXMEs

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableImpl.java
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/MembershipProvider.java
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserConfigurationImpl.java
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserQueryManager.java
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/UserConfiguration.java
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/action/AbstractAuthorizableAction.java
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/action/DefaultAuthorizableActionProvider.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableImpl.java?rev=1421925&r1=1421924&r2=1421925&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableImpl.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableImpl.java
Fri Dec 14 15:19:17 2012
@@ -145,7 +145,7 @@ abstract class AuthorizableImpl implemen
     @Override
     public int hashCode() {
         if (hashCode == 0) {
-            // FIXME: add proper hash-code generation taking repo/workspace/tree-identifier
into account
+            // FIXME OAK-523: add proper hash-code generation taking repo/workspace/tree-identifier
into account
             StringBuilder sb = new StringBuilder();
             sb.append(isGroup() ? "group:" : "user:");
             sb.append(':');
@@ -162,7 +162,7 @@ abstract class AuthorizableImpl implemen
         }
         if (obj instanceof AuthorizableImpl) {
             AuthorizableImpl otherAuth = (AuthorizableImpl) obj;
-            // FIXME: make sure 2 authorizables are based on the same tree/node object
+            // FIXME OAK-523: make sure 2 authorizables are based on the same tree/node object
             return isGroup() == otherAuth.isGroup() && id.equals(otherAuth.id);
         }
         return false;

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/MembershipProvider.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/MembershipProvider.java?rev=1421925&r1=1421924&r2=1421925&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/MembershipProvider.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/MembershipProvider.java
Fri Dec 14 15:19:17 2012
@@ -161,7 +161,7 @@ class MembershipProvider extends Authori
                 Tree membersTree = groupTree.getChild(REP_MEMBERS);
                 if (membersTree != null) {
                     // FIXME: fix.. testing for property name in jr2 wasn't correct.
-                    // TODO: add implementation
+                    // TODO OAK-482: add implementation
                     throw new UnsupportedOperationException("not implemented: isMembers determined
from member-node hierarchy");
                 }
             } else {
@@ -189,7 +189,7 @@ class MembershipProvider extends Authori
         if (useMemberNode(groupTree)) {
             NodeUtil groupNode = new NodeUtil(groupTree);
             NodeUtil membersNode = groupNode.getOrAddChild(REP_MEMBERS, NT_REP_MEMBERS);
-            // TODO: add implementation that allows to index group members
+            // TODO OAK-482: add implementation that allows to index group members
             throw new UnsupportedOperationException("not implemented: addMember with member-node
hierarchy");
         } else {
             PropertyBuilder<String> propertyBuilder = getMembersPropertyBuilder(groupTree);
@@ -207,7 +207,7 @@ class MembershipProvider extends Authori
         if (useMemberNode(groupTree)) {
             Tree membersTree = groupTree.getChild(REP_MEMBERS);
             if (membersTree != null) {
-                // TODO: add implementation
+                // TODO OAK-482: add implementation
                 throw new UnsupportedOperationException("not implemented: remove member from
member-node hierarchy");
             }
         } else {

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserConfigurationImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserConfigurationImpl.java?rev=1421925&r1=1421924&r2=1421925&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserConfigurationImpl.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserConfigurationImpl.java
Fri Dec 14 15:19:17 2012
@@ -84,7 +84,7 @@ public class UserConfigurationImpl exten
     @Nonnull
     @Override
     public AuthorizableActionProvider getAuthorizableActionProvider() {
-        // TODO: add proper implementation
+        // TODO OAK-521: add proper implementation
         AuthorizableActionProvider defProvider = new DefaultAuthorizableActionProvider(securityProvider,
config);
         return config.getConfigValue(UserConstants.PARAM_AUTHORIZABLE_ACTION_PROVIDER, defProvider);
     }

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserQueryManager.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserQueryManager.java?rev=1421925&r1=1421924&r2=1421925&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserQueryManager.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserQueryManager.java
Fri Dec 14 15:19:17 2012
@@ -68,6 +68,7 @@ class UserQueryManager {
 
     @Nonnull
     Iterator<Authorizable> find(Query query) throws RepositoryException {
+        // TODO OAK-253: replace usage of XPATH
         XPathQueryBuilder builder = new XPathQueryBuilder();
         query.build(builder);
         return new XPathQueryEvaluator(builder, userManager, root, userManager.getNamePathMapper()).eval();
@@ -102,7 +103,8 @@ class UserQueryManager {
     @Nonnull
     Iterator<Authorizable> findAuthorizables(String relPath, String value,
                                              boolean exact, AuthorizableType type) throws
RepositoryException {
-        // TODO: replace XPATH
+        // TODO OAK-480: fix authorizable query
+        // TODO OAK-253: replace usage of XPATH
         String statement = buildXPathStatement(relPath, value, exact, type);
         QueryEngine queryEngine = root.getQueryEngine();
         try {

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/UserConfiguration.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/UserConfiguration.java?rev=1421925&r1=1421924&r2=1421925&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/UserConfiguration.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/UserConfiguration.java
Fri Dec 14 15:19:17 2012
@@ -25,7 +25,8 @@ import org.apache.jackrabbit.oak.spi.sec
 import org.apache.jackrabbit.oak.spi.security.user.action.AuthorizableActionProvider;
 
 /**
- * UserContext... TODO
+ * UserConfiguration...
+ * TODO: OAK-522
  */
 public interface UserConfiguration extends SecurityConfiguration {
 

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/action/AbstractAuthorizableAction.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/action/AbstractAuthorizableAction.java?rev=1421925&r1=1421924&r2=1421925&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/action/AbstractAuthorizableAction.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/action/AbstractAuthorizableAction.java
Fri Dec 14 15:19:17 2012
@@ -33,7 +33,7 @@ import org.apache.jackrabbit.oak.spi.sec
  */
 public abstract class AbstractAuthorizableAction implements AuthorizableAction {
 
-    // TODO: review again
+    // TODO OAK-521:: review again
     protected abstract void init(SecurityProvider securityProvider, ConfigurationParameters
config);
 
     //-------------------------------------------------< AuthorizableAction >---

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/action/DefaultAuthorizableActionProvider.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/action/DefaultAuthorizableActionProvider.java?rev=1421925&r1=1421924&r2=1421925&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/action/DefaultAuthorizableActionProvider.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/action/DefaultAuthorizableActionProvider.java
Fri Dec 14 15:19:17 2012
@@ -38,7 +38,7 @@ public class DefaultAuthorizableActionPr
 
     @Override
     public List<AuthorizableAction> getAuthorizableActions() {
-        // TODO : create and initialize actions from configuration
+        // TODO OAK-521: create and initialize actions from configuration
         return Collections.emptyList();
     }
 }
\ No newline at end of file



Mime
View raw message