jackrabbit-oak-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ju...@apache.org
Subject svn commit: r1420194 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueFactoryImpl.java
Date Tue, 11 Dec 2012 14:26:29 GMT
Author: jukka
Date: Tue Dec 11 14:26:28 2012
New Revision: 1420194

URL: http://svn.apache.org/viewvc?rev=1420194&view=rev
Log:
OAK-350: Unify PropertyState and CoreValue

Use instance equality for ErrorValues, otherwise Sonar complains about the broken equals()
contract.

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueFactoryImpl.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueFactoryImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueFactoryImpl.java?rev=1420194&r1=1420193&r2=1420194&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueFactoryImpl.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueFactoryImpl.java
Tue Dec 11 14:26:28 2012
@@ -319,15 +319,6 @@ public class ValueFactoryImpl implements
             return new RepositoryException("Inaccessible value", exception);
         }
 
-        /**
-         * Error values are never equal.
-         * @return {@code false}
-         */
-        @Override
-        public boolean equals(Object obj) {
-            return false;
-        }
-
         @Override
         public String toString() {
             return "Inaccessible value: " + exception.getMessage();



Mime
View raw message