jackrabbit-oak-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ang...@apache.org
Subject svn commit: r1404277 - /jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/security/user/UserProviderTest.java
Date Wed, 31 Oct 2012 18:12:23 GMT
Author: angela
Date: Wed Oct 31 18:12:21 2012
New Revision: 1404277

URL: http://svn.apache.org/viewvc?rev=1404277&view=rev
Log:
OAK-50 : Implement User Management (WIP)

fix tests (equality of authorizable trees)

Modified:
    jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/security/user/UserProviderTest.java

Modified: jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/security/user/UserProviderTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/security/user/UserProviderTest.java?rev=1404277&r1=1404276&r2=1404277&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/security/user/UserProviderTest.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/security/user/UserProviderTest.java
Wed Oct 31 18:12:21 2012
@@ -41,10 +41,6 @@ import static org.junit.Assert.fail;
 
 /**
  * UserProviderImplTest...
- *
- * TODO: create tests with custom config that persists changes (currently fails since config
used in UserValidator is different)
- * TODO: add tests for setProtectedProperty (might still be refactored...)
- * TODO: add tests for findAuthorizables once implementation is ready
  */
 public class UserProviderTest {
 
@@ -261,13 +257,12 @@ public class UserProviderTest {
         Tree user = up.createUser("shams", null);
         Tree a = up.getAuthorizableByPath(user.getPath());
         assertNotNull(a);
-        // FIXME there is no additional contract on equality of Tree instances neither do
the various accessors guarantee to return the same instance on call
-        assertEquals(user, a);
+        assertEquals(user.getPath(), a.getPath());
 
         Tree group = up.createGroup("devs", null);
         a = up.getAuthorizableByPath(group.getPath());
         assertNotNull(a);
-        assertEquals(group, a);
+        assertEquals(group.getPath(), a.getPath());
     }
 
     @Test



Mime
View raw message