jackrabbit-oak-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mdue...@apache.org
Subject svn commit: r1404097 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/NodeTypeImpl.java
Date Wed, 31 Oct 2012 11:24:05 GMT
Author: mduerig
Date: Wed Oct 31 11:24:05 2012
New Revision: 1404097

URL: http://svn.apache.org/viewvc?rev=1404097&view=rev
Log:
OAK-250 : Enforce jcr constraints for 'protected' items
TODO

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/NodeTypeImpl.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/NodeTypeImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/NodeTypeImpl.java?rev=1404097&r1=1404096&r2=1404097&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/NodeTypeImpl.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/NodeTypeImpl.java
Wed Oct 31 11:24:05 2012
@@ -276,7 +276,7 @@ class NodeTypeImpl implements NodeType {
             return !def.isProtected() &&
                     meetsTypeConstraints(value, def.getRequiredType()) &&
                     meetsValueConstraints(value, def.getValueConstraints());
-        } catch (RepositoryException e) {
+        } catch (RepositoryException e) {  // TODO don't use exceptions for flow control.
Use internal method in ReadOnlyNodeTypeManager instead.
             log.debug(e.getMessage());
             return false;
         }
@@ -295,7 +295,7 @@ class NodeTypeImpl implements NodeType {
             return !def.isProtected() &&
                     meetsTypeConstraints(values, def.getRequiredType()) &&
                     meetsValueConstraints(values, def.getValueConstraints());
-        } catch (RepositoryException e) {
+        } catch (RepositoryException e) {  // TODO don't use exceptions for flow control.
Use internal method in ReadOnlyNodeTypeManager instead.
             log.debug(e.getMessage());
             return false;
         }



Mime
View raw message