jackrabbit-oak-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ang...@apache.org
Subject svn commit: r1401571 - in /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api: BlobFactory.java Root.java
Date Wed, 24 Oct 2012 07:33:03 GMT
Author: angela
Date: Wed Oct 24 07:33:02 2012
New Revision: 1401571

URL: http://svn.apache.org/viewvc?rev=1401571&view=rev
Log:
OAK-392 : Review ContentSession#createBlob

add some additional comments and TODOs

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/BlobFactory.java
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/Root.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/BlobFactory.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/BlobFactory.java?rev=1401571&r1=1401570&r2=1401571&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/BlobFactory.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/BlobFactory.java
Wed Oct 24 07:33:02 2012
@@ -20,7 +20,13 @@ import java.io.IOException;
 import java.io.InputStream;
 
 /**
- * BlobFactory... TODO
+ * BlobFactory...
+ * TODO review again if we really need/want to expose that in the OAK API
+ * TODO in particular exposing this interface (and Blob) requires additional thoughts on
+ * TODO - lifecycle of the factory,
+ * TODO - lifecycle of the Blob,
+ * TODO - access restrictions and how permissions are enforced on blob creation
+ * TODO - searchability, versioning and so forth
  */
 public interface BlobFactory {
 

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/Root.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/Root.java?rev=1401571&r1=1401570&r2=1401571&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/Root.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/Root.java Wed
Oct 24 07:33:02 2012
@@ -133,7 +133,7 @@ public interface Root {
     SessionQueryEngine getQueryEngine();
 
     /**
-     * Returns the blob factory. TODO: specify life-cycle of that factory....
+     * Returns the blob factory (TODO: review if that really belongs to the OAK-API. see
also todos on BlobFactory)
      *
      * @return the blob factory.
      */



Mime
View raw message