Return-Path: X-Original-To: apmail-jackrabbit-oak-commits-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DDE1EDC14 for ; Tue, 21 Aug 2012 14:11:54 +0000 (UTC) Received: (qmail 29446 invoked by uid 500); 21 Aug 2012 14:11:54 -0000 Delivered-To: apmail-jackrabbit-oak-commits-archive@jackrabbit.apache.org Received: (qmail 29407 invoked by uid 500); 21 Aug 2012 14:11:54 -0000 Mailing-List: contact oak-commits-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-commits@jackrabbit.apache.org Received: (qmail 29396 invoked by uid 99); 21 Aug 2012 14:11:54 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Aug 2012 14:11:54 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Aug 2012 14:11:53 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 9671B23889B3; Tue, 21 Aug 2012 14:11:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1375556 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeBuilder.java Date: Tue, 21 Aug 2012 14:11:10 -0000 To: oak-commits@jackrabbit.apache.org From: mduerig@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120821141110.9671B23889B3@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: mduerig Date: Tue Aug 21 14:11:10 2012 New Revision: 1375556 URL: http://svn.apache.org/viewvc?rev=1375556&view=rev Log: OAK-266: Clarify Tree interface Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeBuilder.java Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeBuilder.java URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeBuilder.java?rev=1375556&r1=1375555&r2=1375556&view=diff ============================================================================== --- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeBuilder.java (original) +++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeBuilder.java Tue Aug 21 14:11:10 2012 @@ -20,6 +20,7 @@ import java.util.List; import javax.annotation.Nonnull; +import com.sun.istack.internal.NotNull; import org.apache.jackrabbit.oak.api.CoreValue; import org.apache.jackrabbit.oak.api.PropertyState; @@ -66,10 +67,11 @@ public interface NodeBuilder { * @param name name child node containing the sub-tree * @param nodeState sub-tree */ - void setNode(String name, NodeState nodeState); + void setNode(String name, @NotNull NodeState nodeState); /** - * Remove a child node + * Remove a child node. This method has no effect if a + * property of the given {@code name} does not exist. * @param name name of the child node */ void removeNode(String name); @@ -103,7 +105,7 @@ public interface NodeBuilder { * @param name property name * @param value */ - void setProperty(String name, CoreValue value); + void setProperty(String name, @NotNull CoreValue value); /** * Set a property. @@ -111,10 +113,11 @@ public interface NodeBuilder { * @param name property name * @param values */ - void setProperty(String name, List values); + void setProperty(String name, @NotNull List values); /** - * Remove the named property + * Remove the named property. This method has no effect if a + * property of the given {@code name} does not exist. * @param name name of the property */ void removeProperty(String name);