jackrabbit-oak-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mdue...@apache.org
Subject svn commit: r1375556 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeBuilder.java
Date Tue, 21 Aug 2012 14:11:10 GMT
Author: mduerig
Date: Tue Aug 21 14:11:10 2012
New Revision: 1375556

URL: http://svn.apache.org/viewvc?rev=1375556&view=rev
Log:
OAK-266: Clarify Tree interface

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeBuilder.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeBuilder.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeBuilder.java?rev=1375556&r1=1375555&r2=1375556&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeBuilder.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeBuilder.java
Tue Aug 21 14:11:10 2012
@@ -20,6 +20,7 @@ import java.util.List;
 
 import javax.annotation.Nonnull;
 
+import com.sun.istack.internal.NotNull;
 import org.apache.jackrabbit.oak.api.CoreValue;
 import org.apache.jackrabbit.oak.api.PropertyState;
 
@@ -66,10 +67,11 @@ public interface NodeBuilder {
      * @param name  name child node containing the sub-tree
      * @param nodeState  sub-tree
      */
-    void setNode(String name, NodeState nodeState);
+    void setNode(String name, @NotNull NodeState nodeState);
 
     /**
-     * Remove a child node
+     * Remove a child node. This method has no effect if a
+     * property of the given {@code name} does not exist.
      * @param name  name of the child node
      */
     void removeNode(String name);
@@ -103,7 +105,7 @@ public interface NodeBuilder {
      * @param name property name
      * @param value
      */
-    void setProperty(String name, CoreValue value);
+    void setProperty(String name, @NotNull CoreValue value);
 
     /**
      * Set a property.
@@ -111,10 +113,11 @@ public interface NodeBuilder {
      * @param name property name
      * @param values
      */
-    void setProperty(String name, List<CoreValue> values);
+    void setProperty(String name, @NotNull List<CoreValue> values);
 
     /**
-     * Remove the named property
+     * Remove the named property. This method has no effect if a
+     * property of the given {@code name} does not exist.
      * @param name  name of the property
      */
     void removeProperty(String name);



Mime
View raw message