jackrabbit-oak-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mdue...@apache.org
Subject svn commit: r1344262 - in /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak: plugins/name/NameValidator.java plugins/type/TypeValidator.java spi/commit/Validator.java
Date Wed, 30 May 2012 13:54:43 GMT
Author: mduerig
Date: Wed May 30 13:54:43 2012
New Revision: 1344262

URL: http://svn.apache.org/viewvc?rev=1344262&view=rev
Log:
OAK-68 - Extension point for commit validation
Validator.childNodeDeleted should have void return type since there is nothing to validated
on a deleted node

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/name/NameValidator.java
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/type/TypeValidator.java
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/commit/Validator.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/name/NameValidator.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/name/NameValidator.java?rev=1344262&r1=1344261&r2=1344262&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/name/NameValidator.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/name/NameValidator.java
Wed May 30 13:54:43 2012
@@ -98,9 +98,8 @@ class NameValidator implements Validator
     }
 
     @Override
-    public Validator childNodeDeleted(String name, NodeState before) {
+    public void childNodeDeleted(String name, NodeState before) {
         // do nothing
-        return this;
     }
 
 }

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/type/TypeValidator.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/type/TypeValidator.java?rev=1344262&r1=1344261&r2=1344262&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/type/TypeValidator.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/type/TypeValidator.java
Wed May 30 13:54:43 2012
@@ -91,9 +91,8 @@ class TypeValidator implements Validator
     }
 
     @Override
-    public Validator childNodeDeleted(String name, NodeState before) {
+    public void childNodeDeleted(String name, NodeState before) {
         // TODO: validate removed child node
-        return this;
     }
 
 }

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/commit/Validator.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/commit/Validator.java?rev=1344262&r1=1344261&r2=1344262&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/commit/Validator.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/commit/Validator.java
Wed May 30 13:54:43 2012
@@ -46,8 +46,7 @@ public interface Validator {
             String name, NodeState before, NodeState after)
             throws CommitFailedException;
 
-    @Nonnull
-    Validator childNodeDeleted(String name, NodeState before)
+    void childNodeDeleted(String name, NodeState before)
             throws CommitFailedException;
 
 }



Mime
View raw message