From oak-commits-return-163-apmail-jackrabbit-oak-commits-archive=jackrabbit.apache.org@jackrabbit.apache.org Thu Apr 5 08:52:43 2012 Return-Path: X-Original-To: apmail-jackrabbit-oak-commits-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2566697E3 for ; Thu, 5 Apr 2012 08:52:43 +0000 (UTC) Received: (qmail 72099 invoked by uid 500); 5 Apr 2012 08:52:43 -0000 Delivered-To: apmail-jackrabbit-oak-commits-archive@jackrabbit.apache.org Received: (qmail 72074 invoked by uid 500); 5 Apr 2012 08:52:43 -0000 Mailing-List: contact oak-commits-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-commits@jackrabbit.apache.org Delivered-To: mailing list oak-commits@jackrabbit.apache.org Received: (qmail 72065 invoked by uid 99); 5 Apr 2012 08:52:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Apr 2012 08:52:42 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com designates 209.85.212.172 as permitted sender) Received: from [209.85.212.172] (HELO mail-wi0-f172.google.com) (209.85.212.172) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Apr 2012 08:52:36 +0000 Received: by wibhj6 with SMTP id hj6so1388398wib.1 for ; Thu, 05 Apr 2012 01:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=5/blS706VM8lggGc7D8TJHj0TvaRWXKKMCCMI0uSVXI=; b=DIc10e4cNaFrPro+MgRywB27aDdA3mU0ftu4AUNFfbqgUyNnPCA/HyOeinMYtEO2+0 RDs4wwfAtDtZ6KYRDohyPSsK25qyd+kDJPh8e77l2+qsN8gfDf5qWqouOTaGlURPS3Bm rDH+5AzKZS7ePA7AzADIOOIC1BiO2E6yLYdunWDLnBpONmkk7ZCTnwopHT589jlOBSrZ TQyv16GBFdBc3IJ/pJLFwGu8xGHXT6/sdyl/6VFIr/oSasOC5TfbCpWmY4riwZYz+CWp V1fS/aLFe6ziyaqlReSsnxb6M+bI3nBkXDrnqOeZaDAftYzeZEfPr/uySyhOSCOBhTug WbEA== Received: by 10.180.94.33 with SMTP id cz1mr2781809wib.13.1333615935328; Thu, 05 Apr 2012 01:52:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.180.87.196 with HTTP; Thu, 5 Apr 2012 01:51:55 -0700 (PDT) In-Reply-To: References: <4F7D5845.4060400@apache.org> From: Jukka Zitting Date: Thu, 5 Apr 2012 10:51:55 +0200 Message-ID: Subject: Re: svn commit: r1309458 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/KernelNodeState.java To: oak-commits@jackrabbit.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Hi, On Thu, Apr 5, 2012 at 10:48 AM, Thomas Mueller wrote: > I think the pattern "if nodeExists then getNodes" should be avoided also > because the node might have been deleted just after calling nodeExists, > depending on the underlying storage. Revisions are immutable, so this should never happen. BR, Jukka Zitting