From oak-commits-return-258-apmail-jackrabbit-oak-commits-archive=jackrabbit.apache.org@jackrabbit.apache.org Thu Apr 12 14:31:26 2012 Return-Path: X-Original-To: apmail-jackrabbit-oak-commits-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 29B569545 for ; Thu, 12 Apr 2012 14:31:26 +0000 (UTC) Received: (qmail 98706 invoked by uid 500); 12 Apr 2012 14:31:26 -0000 Delivered-To: apmail-jackrabbit-oak-commits-archive@jackrabbit.apache.org Received: (qmail 98683 invoked by uid 500); 12 Apr 2012 14:31:26 -0000 Mailing-List: contact oak-commits-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-commits@jackrabbit.apache.org Delivered-To: mailing list oak-commits@jackrabbit.apache.org Received: (qmail 98670 invoked by uid 99); 12 Apr 2012 14:31:26 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2012 14:31:26 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of julian.reschke@gmx.de designates 213.165.64.23 as permitted sender) Received: from [213.165.64.23] (HELO mailout-de.gmx.net) (213.165.64.23) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 12 Apr 2012 14:31:17 +0000 Received: (qmail invoked by alias); 12 Apr 2012 14:30:55 -0000 Received: from mail.greenbytes.de (EHLO [192.168.1.140]) [217.91.35.233] by mail.gmx.net (mp037) with SMTP; 12 Apr 2012 16:30:55 +0200 X-Authenticated: #1915285 X-Provags-ID: V01U2FsdGVkX19DXWN9ylRDTdiAK/wvhQDtu29rIvGyn0hi8d86o9 zeDt0fgLAuOaSu Message-ID: <4F86E71F.1080609@gmx.de> Date: Thu, 12 Apr 2012 16:30:55 +0200 From: Julian Reschke User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: oak-commits@jackrabbit.apache.org CC: thomasm@apache.org Subject: Re: svn commit: r1325270 - /jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/blobs/DbBlobStoreTest.java References: <20120412140856.8FB7E23889E0@eris.apache.org> <4F86E482.5020904@gmx.de> In-Reply-To: <4F86E482.5020904@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Virus-Checked: Checked by ClamAV on apache.org On 2012-04-12 16:19, Julian Reschke wrote: > On 2012-04-12 16:08, thomasm@apache.org wrote: >> Author: thomasm >> Date: Thu Apr 12 14:08:56 2012 >> New Revision: 1325270 >> >> URL: http://svn.apache.org/viewvc?rev=1325270&view=rev >> Log: >> OAK-58 connection leak in test case >> OAK-60 occasional test case failure DbBlobStoreTest#testGarbageCollection >> >> Modified: >> jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/blobs/DbBlobStoreTest.java >> >> ... > > > What? :-) > > 1) How is this supposed to fix OAK-58? > > 2) That being said, I now get all kinds of NPEs? > > Is this again a Win-only problem??? > ... Nope, it's because the derived test classes do not set "cp" in the setup method, but then do not override tearDown(). Best regards, Julian