jackrabbit-oak-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Reschke <julian.resc...@gmx.de>
Subject Re: svn commit: r1325270 - /jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/blobs/DbBlobStoreTest.java
Date Thu, 12 Apr 2012 15:07:29 GMT
On 2012-04-12 17:04, Jukka Zitting wrote:
> Hi,
>
> On Thu, Apr 12, 2012 at 4:30 PM, Julian Reschke<julian.reschke@gmx.de>  wrote:
>> Nope, it's because the derived test classes do not set "cp" in the setup
>> method, but then do not override tearDown().
>
> I notice you fixed that in revision 1325296.
>
> I cleaned things up a bit more in revision 1325399 by moving the
> generic tests away from DbBlobStoreTest to an abstract base class
> that's shared by the Db, File, Memory and Mongo tests without having
> all of them inherit and/or override the Db set up and tear down code.
> ...

Yes, that's a better approach.

Thanks!

Mime
View raw message