From dev-return-54683-archive-asf-public=cust-asf.ponee.io@jackrabbit.apache.org Tue Oct 6 16:19:20 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 93F57180636 for ; Tue, 6 Oct 2020 18:19:20 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id C2F9B12250B for ; Tue, 6 Oct 2020 16:19:19 +0000 (UTC) Received: (qmail 79607 invoked by uid 500); 6 Oct 2020 16:19:19 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 79592 invoked by uid 99); 6 Oct 2020 16:19:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Oct 2020 16:19:19 +0000 From: =?utf-8?q?GitBox?= To: dev@jackrabbit.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bjackrabbit-oak=5D_stefan-egli_commented_on_pull_re?= =?utf-8?q?quest_=23247=3A_OAK-9176_=3A_sweep2_PR_for_review?= Message-ID: <160200115898.32230.12493091752111515910.asfpy@gitbox.apache.org> Date: Tue, 06 Oct 2020 16:19:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: stefan-egli commented on pull request #247: URL: https://github.com/apache/jackrabbit-oak/pull/247#issuecomment-704384335 > I have only one minor suggestion for a potential improvement. The sweep2 thread can currently block the DocumentNodeStore shutdown. The AtomicBoolean DocumentNodeStore#isDisposed could be used as a poison pill in MissingBcSweeper2. Good idea. Added in [this commit](https://github.com/apache/jackrabbit-oak/pull/247/commits/48ab434ad284d0a4c7c7299da4692ec9d73e502b) (including a test case to cover this scenario) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org