jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jackrabbit-oak] stefan-egli commented on pull request #247: OAK-9176 : sweep2 PR for review
Date Tue, 06 Oct 2020 16:19:18 GMT

stefan-egli commented on pull request #247:
URL: https://github.com/apache/jackrabbit-oak/pull/247#issuecomment-704384335


   > I have only one minor suggestion for a potential improvement. The sweep2 thread can
currently block the DocumentNodeStore shutdown. The AtomicBoolean DocumentNodeStore#isDisposed
could be used as a poison pill in MissingBcSweeper2.
   
   Good idea. Added in [this commit](https://github.com/apache/jackrabbit-oak/pull/247/commits/48ab434ad284d0a4c7c7299da4692ec9d73e502b)
(including a test case to cover this scenario)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message