jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (JCR-4301) get rid of JSR 305 dependency
Date Wed, 05 Jun 2019 06:09:00 GMT

    [ https://issues.apache.org/jira/browse/JCR-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526293#comment-16526293
] 

Julian Reschke edited comment on JCR-4301 at 6/5/19 6:08 AM:
-------------------------------------------------------------

[^JCR-4301-jackrabbit-projects.diff] is (was?) an attempt to define custom Jackrabbit annotations,
preserving the non-qualified class name if the JSR-305 annotations in order to minimize diffs.

I tried the customer o.a.j.annotations.CheckForNull annotation, and spotbugs won't use it.
See also https://github.com/spotbugs/spotbugs/blob/master/spotbugs/src/main/java/edu/umd/cs/findbugs/ba/NullnessAnnotation.java.

So maybe we should stick to the previously agreed upon approach and live with the fact that
we'll have to touch lots of code lines.


was (Author: reschke):
[^JCR-4301-jackrabbit-projects.diff] is (was?) an attempt to define custom Jackrabbit annotations,
preserving the non-qualified class name if the JSR-305 annotations in order to minimize diffs.

I tried the customer o.a.j.annotations.CheckForNull annotation, and spotbugs won't use it.
See alsohttps://github.com/spotbugs/spotbugs/blob/master/spotbugs/src/main/java/edu/umd/cs/findbugs/ba/NullnessAnnotation.java.

So maybe we should stick to the previously agreed upon approach and live with the fact that
we'll have to touch lots of code lines.

> get rid of JSR 305 dependency
> -----------------------------
>
>                 Key: JCR-4301
>                 URL: https://issues.apache.org/jira/browse/JCR-4301
>             Project: Jackrabbit Content Repository
>          Issue Type: Task
>          Components: jackrabbit-api
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Major
>             Fix For: 2.18, 2.17.4, 2.16.3
>
>         Attachments: JCR-4301-2.diff, JCR-4301-jackrabbit-projects.diff, JCR-4301.diff,
JCR-4301.diff, convert-annotations.sh
>
>
> We should consider getting rid of the JSR 305 dependency (see <https://blog.codefx.org/java/jsr-305-java-9/>).
Note that we only used the annotations in a few recently changed APIs.
> Further note that we could use spotbugs as replacement for findbugs to detect problems.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message