jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Woonsan Ko <woon...@apache.org>
Subject Re: Splitting jackrabbit-standalone?
Date Thu, 07 Mar 2019 05:40:12 GMT
Hi,

I managed to create a pull request for JCR-4401 [1] -- separating
jackrabbit-standalone-components from jackrabbit-standalone, mainly
for VFS-686 [2]:
With a local build from my feature/JCR-4401 branch, everything seems
working fine: new webdav4 VFS provider [3]. Jackrabbit also seems
successful in unit tests.
If there's no issue, then I'll merge it to trunk next week.

Thanks,

Woonsan

[1] https://github.com/apache/jackrabbit/pull/82
[2] https://issues.apache.org/jira/browse/VFS-686
[3] https://github.com/apache/commons-vfs/pull/52

On Tue, Jan 8, 2019 at 12:19 AM Woonsan Ko <woonsan@apache.org> wrote:
>
> On Thu, Jan 3, 2019 at 11:59 PM Julian Reschke <julian.reschke@gmx.de> wrote:
> >
> > On 2019-01-03 14:30, Woonsan Ko wrote:
> > > Hi,
> > >
> > > I'd like to help fix VFS-686 [1] by upgrading JR dependency from 1.6.5
> > > to 2.18.x for the WebDAV vfs provider. The fix will allow to use
> > > WebDAV DataStore backend again. (Since JR upgraded httpclient to v4.x,
> > > WebDAV backend has been broken.)
> > >
> > > One problem is that the test case for WebDAV vfs provider counts on
> > > jackrabbit-standalone dependency--to start an extended JR Main for
> > > testing--which has been unavailable in maven repos for long time. It's
> > > understandable not to deploy the module as it's too big.
> > > At the same time, it would be awkward if VFS should contain all the
> > > necessary JR dependencies as jackrabbit-standalone does.
> > >
> > > I think it would be nice if we split the module, by moving all the
> > > Java classes and resources with most dependencies, except of
> > > jackrabbit-webapp, to a new maven module (e.g,
> > > "jackrabbit-standalone-components") and having dependency on this new
> > > module and webapp module in jackrabbit-standalone bundle module. This
> > > will let VFS keep the JR dependencies simple and easy.
> > >
> > > How does it sound?
> > > ...
> >
> >
> > Sounds good to me.
>
> Thanks Julian!
> I've created a ticket: https://issues.apache.org/jira/browse/JCR-4401
> My plan is, (a) to create a pull request (for review purpose from
> myself and others if possible), (b) to create another pull request for
> VFS-686 to test and validate with my feature branch, (c) merge (a) if
> everything is okay.
>
> By the way, I don't seem to be able to assign JCR-4401 to myself.
> Could someone allow me to do that?
>
> Kind regards,
>
> Woonsan
>
> >
> > Best regards, Julian

Mime
View raw message