jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (JCR-4008) Restore TestCachingFDS.testDeleteRecord() to fix it with disabling AsyncUpload in unit tests
Date Fri, 11 May 2018 12:26:00 GMT

     [ https://issues.apache.org/jira/browse/JCR-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Julian Reschke updated JCR-4008:
--------------------------------
    Labels: candidate_jcr_2_12  (was: )

> Restore TestCachingFDS.testDeleteRecord() to fix it with disabling AsyncUpload in unit
tests
> --------------------------------------------------------------------------------------------
>
>                 Key: JCR-4008
>                 URL: https://issues.apache.org/jira/browse/JCR-4008
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>    Affects Versions: 2.13.2
>            Reporter: Woonsan Ko
>            Assignee: Amit Jain
>            Priority: Major
>              Labels: candidate_jcr_2_12
>             Fix For: 2.13.4, 2.14
>
>
> The test used to fail occasionally before the test method was commented out by JCR-4006:
> {noformat}
> junit.framework.AssertionFailedError: rec2 should be null
> 	at junit.framework.Assert.fail(Assert.java:50)
> 	at junit.framework.Assert.assertTrue(Assert.java:20)
> 	at junit.framework.Assert.assertNull(Assert.java:237)
> 	at org.apache.jackrabbit.core.data.TestCaseBase.doDeleteRecordTest(TestCaseBase.java:327)
> 	at org.apache.jackrabbit.core.data.TestCaseBase.testDeleteRecord(TestCaseBase.java:192)
> {noformat}
> The main reason of this error is because the underlying backend uses asynchronous writing
threads by default, which is not working well when extending {{org.apache.jackrabbit.core.data.TestCaseBase}}
as mentioned in JCR-4005.
> So, it seems better to fix it again like the following like how JCR-4005 was fixed:
> - Restore the commented out block ({{TestCachingFDS.testDeleteRecord()}}).
> - Provide an option to disable asynchronous writing in all the related backend implementations.
e.g., disable it if {{asyncWritePoolSize}} is zero or smaller.
> - In unit tests, simply disable async writing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message