jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (JCR-4267) ISO8601.parse should support timezone designators in the form ±hhmm and ±hh
Date Thu, 22 Feb 2018 13:01:00 GMT

    [ https://issues.apache.org/jira/browse/JCR-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372763#comment-16372763
] 

Julian Reschke edited comment on JCR-4267 at 2/22/18 1:00 PM:
--------------------------------------------------------------

Not convinced.

The parser purposefully implements the subset defined in https://www.w3.org/TR/NOTE-datetime
and RFC 3339 (I think). Relaxing those constraints would make certain strings parse which
we actually did not want to parse, because the protocols they appear in *require* the use
of that subset.


was (Author: reschke):
Not convinced.

Why does filevault use this format when it never has been supported by the jackrabbit parser?
How is including the timezone offset of any use here?

> ISO8601.parse should support timezone designators in the form ±hhmm and ±hh
> ---------------------------------------------------------------------------
>
>                 Key: JCR-4267
>                 URL: https://issues.apache.org/jira/browse/JCR-4267
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-commons
>    Affects Versions: 2.17.1
>            Reporter: Konrad Windszus
>            Priority: Major
>
> Currently the ISO8601.parse (https://github.com/apache/jackrabbit/blob/86e15df24c68c8132361466c80f65862f8709880/jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/util/ISO8601.java#L86)
method only supports a subset of time designators being specified by ISO8601.
> Namely the ones {{±hhmm}} and {{±hh}} are missing.
> This is currently a problem for Jackrabbit Filevault Maven Package, as that is using
these designators in https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/f53c53102e97d0bb000794ee2976cabecf62e5ad/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/VaultMojo.java#L1038.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message