Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 484C9200CC2 for ; Tue, 20 Jun 2017 09:24:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4783E160BD3; Tue, 20 Jun 2017 07:24:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8ED9F160BE1 for ; Tue, 20 Jun 2017 09:24:04 +0200 (CEST) Received: (qmail 27629 invoked by uid 500); 20 Jun 2017 07:24:03 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 27547 invoked by uid 99); 20 Jun 2017 07:24:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jun 2017 07:24:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 139B0C146C for ; Tue, 20 Jun 2017 07:24:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id yrrn-trK3lX0 for ; Tue, 20 Jun 2017 07:24:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 95BF95FCD7 for ; Tue, 20 Jun 2017 07:24:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BD3F0E0DA7 for ; Tue, 20 Jun 2017 07:24:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 30E122400C for ; Tue, 20 Jun 2017 07:24:00 +0000 (UTC) Date: Tue, 20 Jun 2017 07:24:00 +0000 (UTC) From: "angela (JIRA)" To: dev@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (JCR-4146) json extension is removed by AbstractWebdavServlet on COPY request MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 20 Jun 2017 07:24:05 -0000 [ https://issues.apache.org/jira/browse/JCR-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055266#comment-16055266 ] angela commented on JCR-4146: ----------------------------- [~reschke], patch looks good to me. in order to minimize the risk for regressions i would suggest to run the litmus test-suite for the regular webdav implementation and the TCK tests against the jcr-2-spi-2-webdav setup (using the jcr-remoting). For the latter building _jackrabbit-jcr2dav_ must be run with _-PintegrationTesting_ => the {{org.apache.jackrabbit.jcr2dav.ConformanceTest}} collects the TCK, the jcr2spi test suite and the jcr2spi-security test suite. > json extension is removed by AbstractWebdavServlet on COPY request > ------------------------------------------------------------------ > > Key: JCR-4146 > URL: https://issues.apache.org/jira/browse/JCR-4146 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-webdav > Affects Versions: 2.15.3 > Reporter: Ana Vinatoru > Assignee: Julian Reschke > Attachments: JCR-4146-2.diff, JCR-4146.diff > > > This issue was first observed via crxDE: the user did a copy / paste on a node with the .json extension (let's say test.json). After saving, the new node was named "Copy of test" instead of "Copy of test.json". > I tracked the request to the AbstractWebdavServlet.doCopy method - and this is where the .json extension seems to be lost. > The Destination header sent by crxde includes the extension, but the new resource created in doCopy does not have it. > The request looked like this: > {code:java} > curl -u admin:admin 'http://localhost:4502/crx/server/crx.default/jcr%3aroot/libs/test.json' -X COPY -H 'Overwrite: T' -H 'Destination: /crx/server/crx.default/jcr%3aroot/libs/Copy%20of%20test.json' -v > {code} > To rule out issues in other layers, I tested with the Jackrabbit 2.14.x standalone. > I uploaded the test.json file via WebDav, then executed the following curl request: > {code:java} > curl -u admin:admin 'http://localhost:9001/server/default/jcr:root/test.json' -X COPY -H 'Overwrite: T' -H 'Destination: /server/default/jcr:root/copytest.json' -v > {code} > The new node was created, but instead of being named "copytest.json", it is called "copytest". -- This message was sent by Atlassian JIRA (v6.4.14#64029)