jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-4085) DavEx json should always add type information for Doubles
Date Wed, 14 Dec 2016 20:08:58 GMT

    [ https://issues.apache.org/jira/browse/JCR-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749333#comment-15749333
] 

ASF GitHub Bot commented on JCR-4085:
-------------------------------------

GitHub user justinedelson opened a pull request:

    https://github.com/apache/jackrabbit/pull/50

    JCR-4085 - always include property type data for DOUBLE

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinedelson/jackrabbit issue/JCR-4085

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jackrabbit/pull/50.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #50
    
----
commit 17fcced7191b440330c4a6daae2b0af50c2c6d65
Author: justinedelson <justin@justinedelson.com>
Date:   2016-12-14T20:06:42Z

    JCR-4085 - always include property type data for DOUBLE

----


> DavEx json should always add type information for Doubles
> ---------------------------------------------------------
>
>                 Key: JCR-4085
>                 URL: https://issues.apache.org/jira/browse/JCR-4085
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-server
>    Affects Versions: 2.12.6
>            Reporter: Alexander Klimetschek
>
> In JSON, there is only a single numeric type which can be both integer and floating point.
A floating point with a ".0" decimal will look like an integer, e.g. "5.0" => "5", serialized
or interpreted as such by parsers.
> Hence to correctly keep the type information for davex clients, the type information
in the separate ":<prop>" property should always be included for double jcr properties,
in [JsonWriter.requiresTypeInfo()|https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/server/remoting/davex/JsonWriter.java#L221-L236].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message