jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shashank Gupta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3754) [jackrabbit-aws-ext] Add retry logic to S3 asynchronous failed upload
Date Fri, 21 Mar 2014 13:24:42 GMT

    [ https://issues.apache.org/jira/browse/JCR-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943047#comment-13943047
] 

Shashank Gupta commented on JCR-3754:
-------------------------------------

>As AsyncUploadCallback is part of API it needs to be documented better. What is the purpose
of file and identifier and what is callback used for
callback is used to reflect status of asynchronous upload to backed for identifier and file.
added more javadocs to it. 

>Using a generic argument map should be avoided. I would prefer if the callback is modelled
on FutureCallback.
done. 

>DataStoreException getting lost
logged as warning.

>Logs should be warning
done. 

All logging changed to slf4j parameterized  logging. 

> [jackrabbit-aws-ext] Add retry logic to S3 asynchronous failed upload
> ---------------------------------------------------------------------
>
>                 Key: JCR-3754
>                 URL: https://issues.apache.org/jira/browse/JCR-3754
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-data
>    Affects Versions: 2.7.5
>            Reporter: Shashank Gupta
>            Assignee: Chetan Mehrotra
>             Fix For: 2.7.6
>
>         Attachments: JCR-3754.patch, JCR-3754V2.patch
>
>
> Currently  s3 asynchronous uploads are not retried after failure. since failed upload
file is served from local cache it doesn't hamper datastore functionality. During next  restart
all accumulated failed upload files are uploaded to s3 in synchronized manner. 
> There should be retry logic for failed s3 asynchronous upload so that failed uploads
are not accumulated. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message