jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shashank Gupta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3743) failing test if aws extensions
Date Thu, 20 Mar 2014 11:46:44 GMT

    [ https://issues.apache.org/jira/browse/JCR-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941643#comment-13941643
] 

Shashank Gupta commented on JCR-3743:
-------------------------------------

>No reason for Thread.sleep().
Btw,  found 61 instances of Thread.sleep in jackrabbit code. 
{noformat}
Search "Thread.sleep" (63 hits in 41 files)
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\main\java\org\apache\jackrabbit\core\gc\GarbageCollector.java
(2 hits)
	Line 328:                 Thread.sleep(sleep);
	Line 481:                     Thread.sleep(testDelay);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\main\java\org\apache\jackrabbit\core\journal\DatabaseJournal.java
(1 hits)
	Line 863:                         Thread.sleep(sleepTime);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\main\java\org\apache\jackrabbit\core\journal\MemoryJournal.java
(2 hits)
	Line 127:             Thread.sleep(writeDelay);
	Line 338:                 Thread.sleep(readDelay);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\main\java\org\apache\jackrabbit\core\observation\ObservationDispatcher.java
(1 hits)
	Line 264:                     Thread.sleep(100);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\main\java\org\apache\jackrabbit\core\persistence\db\DatabasePersistenceManager.java
(1 hits)
	Line 851:             Thread.sleep(SLEEP_BEFORE_RECONNECT);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\main\java\org\apache\jackrabbit\core\persistence\pool\BundleDbPersistenceManager.java
(1 hits)
	Line 508:                     Thread.sleep(100);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\main\java\org\apache\jackrabbit\core\util\CooperativeFileLock.java
(5 hits)
	Line 170:                     Thread.sleep(2 * LOCK_SLEEP);
	Line 179:                 Thread.sleep(SLEEP_GAP);
	Line 225:                             Thread.sleep(LOCK_SLEEP);
	Line 258:             Thread.sleep(time);
	Line 315:             Thread.sleep(sleep);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\AbstractConcurrencyTest.java
(1 hits)
	Line 128:                     Thread.sleep(5 * 1000);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\CachingHierarchyManagerTest.java
(1 hits)
	Line 73:         Thread.sleep(1000);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\ConcurrencyTest.java
(2 hits)
	Line 64:                 Thread.sleep(100);
	Line 98:                 Thread.sleep(l);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\ConcurrentImportTest.java
(1 hits)
	Line 116:                             Thread.sleep(1);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\ConcurrentSaveTest.java
(1 hits)
	Line 98:                             Thread.sleep(0, 50);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\ConcurrentWorkspaceCopyTest.java
(1 hits)
	Line 98:                 Thread.sleep(l);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\data\GarbageCollectorTest.java
(3 hits)
	Line 163:             Thread.sleep(2000);
	Line 203:         Thread.sleep(100);
	Line 224:             Thread.sleep(2000);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\data\GCConcurrentTest.java
(3 hits)
	Line 87:         Thread.sleep(10);
	Line 98:         Thread.sleep(10);
	Line 100:         Thread.sleep(10);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\data\GCSubtreeMoveTest.java
(1 hits)
	Line 143:             Thread.sleep(2200);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\data\GCThread.java
(1 hits)
	Line 65:                 Thread.sleep(10);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\fs\AbstractFileSystemTest.java
(1 hits)
	Line 128:         Thread.sleep(100);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\integration\benchmark\ItemStateCacheSyncTest.java
(2 hits)
	Line 97:         Thread.sleep(3000);
	Line 103:         Thread.sleep(10000);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\integration\ConcurrentQueryTest.java
(1 hits)
	Line 233:                     Thread.sleep(10);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\integration\daily\ItemStateHierarchyManagerDeadlockTest.java
(1 hits)
	Line 94:                 Thread.sleep(1000);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\integration\GQLTest.java
(1 hits)
	Line 413:                     Thread.sleep(1000);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\integration\InterruptedQueryTest.java
(1 hits)
	Line 117:             Thread.sleep((long) (100.0 * Math.random())); 
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\integration\random\operation\Operation.java
(1 hits)
	Line 80:             Thread.sleep(rand.nextInt(maxRandomWait));
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\lock\LockTimeoutTest.java
(1 hits)
	Line 73:             Thread.sleep(100);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\LockedWrapperTest.java
(2 hits)
	Line 151:                         Thread.sleep(random.nextInt(100));
	Line 326:                     Thread.sleep(random.nextInt(100));
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\LockTest.java
(3 hits)
	Line 87:                             Thread.sleep(new Random().nextInt(100));
	Line 155:                             Thread.sleep(new Random().nextInt(100));
	Line 235:                             Thread.sleep(new Random().nextInt(100));
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\query\lucene\IndexingQueueTest.java
(1 hits)
	Line 120:             Thread.sleep(50);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\query\lucene\SearchIndexConsistencyCheckTest.java
(1 hits)
	Line 291:             Thread.sleep(100);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\query\lucene\SlowQueryHandler.java
(1 hits)
	Line 35:             Thread.sleep(INITIALIZATION_DELAY);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\query\lucene\SynonymProviderTest.java
(1 hits)
	Line 61:             Thread.sleep(1 * 1000);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\ReadWhileSaveTest.java
(1 hits)
	Line 55:                 Thread.sleep(100);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\state\AbstractISMLockingTest.java
(1 hits)
	Line 222:         Thread.sleep(100);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-core\src\test\java\org\apache\jackrabbit\core\state\DefaultISMLockingDeadlockTest.java
(1 hits)
	Line 45:         Thread.sleep(100);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-data\src\main\java\org\apache\jackrabbit\core\data\MultiDataStore.java
(4 hits)
	Line 549:                         Thread.sleep(sleepTime);
	Line 615:                     Thread.sleep(sleepBetweenRecords);
	Line 656:                         Thread.sleep(sleepTime);
	Line 688:                         Thread.sleep(sleepBetweenRecords);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-data\src\main\java\org\apache\jackrabbit\core\util\db\ConnectionHelper.java
(1 hits)
	Line 570:                             Thread.sleep(SLEEP_BETWEEN_RETRIES_MS);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-data\src\test\java\org\apache\jackrabbit\core\data\TestCaseBase.java
(2 hits)
	Line 445:         Thread.sleep(2000);
	Line 670:                 Thread.sleep(1);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-data\src\test\java\org\apache\jackrabbit\core\data\TestLocalCache.java
(2 hits)
	Line 158:             Thread.sleep(1000);
	Line 249:             Thread.sleep(1000);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-jcr-commons\src\test\java\org\apache\jackrabbit\util\TimerTest.java
(2 hits)
	Line 54:         Thread.sleep(testDelay);
	Line 63:         Thread.sleep(Timer.IDLE_TIME + 2 * Timer.CHECKER_INTERVAL);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-jcr-tests\src\main\java\org\apache\jackrabbit\test\api\observation\EventJournalTest.java
(2 hits)
	Line 61:             Thread.sleep(1);
	Line 243:                 Thread.sleep(1);
  C:\sourceCode\jackrabbit-svn\jackrabbit-svn\jackrabbit-jcr-tests\src\main\java\org\apache\jackrabbit\test\api\observation\GetDateTest.java
(1 hits)
{noformat}

> failing test if aws extensions
> ------------------------------
>
>                 Key: JCR-3743
>                 URL: https://issues.apache.org/jira/browse/JCR-3743
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>            Reporter: Julian Reschke
>            Assignee: Dominique Pfister
>            Priority: Minor
>
> On Win7/64bit/corei7:
> Failed tests:
>   testDeleteAllOlderThan(org.apache.jackrabbit.aws.ext.ds.TestInMemDs)
>   testDeleteAllOlderThan(org.apache.jackrabbit.aws.ext.ds.TestInMemDsCacheOff)
> Likely because of incorrect assumptions about System.currentTimeMillis()



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message