jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominique Pfister (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (JCR-3729) S3 Datastore optimizations
Date Wed, 12 Mar 2014 14:45:43 GMT

    [ https://issues.apache.org/jira/browse/JCR-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931823#comment-13931823
] 

Dominique Pfister edited comment on JCR-3729 at 3/12/14 2:45 PM:
-----------------------------------------------------------------

Thanks to [~reschke] fixing the svn:eol-style problem, I was able to apply the patch.

[~shgupta], did you ever try to build the project after entering your changes? You introduced
a cyclic dependency between jackrabbit-core and jackrabbit-data, which becomes visible by
merely entering {{mvn clean}} on parent folder jackrabbit:
{code}
[ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.apache.jackrabbit:jackrabbit-core:2.8-SNAPSHOT'}'
and 'Vertex{label='org.apache.jackrabbit:jackrabbit-data:2.8-SNAPSHOT'}' introduces to cycle
in the graph org.apache.jackrabbit:jackrabbit-data:2.8-SNAPSHOT --> org.apache.jackrabbit:jackrabbit-core:2.8-SNAPSHOT
--> org.apache.jackrabbit:jackrabbit-data:2.8-SNAPSHOT -> [Help 1]
{code}
again: what was the reason for moving classes to jackrabbit-data?

You further introduced a class {{o.a.j.core.util.NamedThreadFactory.java}} in jackrabbit-data
and this package name clashes with an identical package name in jackrabbit-core and leads
to a split-package warning when building the bundle. You should use a different package name.

bq. Yes. It is more structured.
Hm, I disagree: in file S3Backend you (or your IDE) moved instance variables in front of class
variables. This again does not comply with standard coding conventions.


was (Author: dpfister):
Thanks to [~reschke] fixing the svn:eol-style problem, I was able to apply the patch.

[~shgupta], did you ever try to build the project after entering your changes? You introduced
a cyclic dependency between jackrabbit-core and jackrabbit-data, which becomes visible by
merely entering {{mvn clean}} on parent folder jackrabbit:
{code}
[ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.apache.jackrabbit:jackrabbit-core:2.8-SNAPSHOT'}'
and 'Vertex{label='org.apache.jackrabbit:jackrabbit-data:2.8-SNAPSHOT'}' introduces to cycle
in the graph org.apache.jackrabbit:jackrabbit-data:2.8-SNAPSHOT --> org.apache.jackrabbit:jackrabbit-core:2.8-SNAPSHOT
--> org.apache.jackrabbit:jackrabbit-data:2.8-SNAPSHOT -> [Help 1]
{code}

You further introduced a class {{o.a.j.core.util.NamedThreadFactory.java}} in jackrabbit-data
and this package name clashes with an identical package name in jackrabbit-core and leads
to a split-package warning when building the bundle. You should use a different package name.

bq. Yes. It is more structured.
Hm, I disagree: in file S3Backend you (or your IDE) moved instance variables in front of class
variables. This again does not comply with standard coding conventions.

> S3 Datastore optimizations
> --------------------------
>
>                 Key: JCR-3729
>                 URL: https://issues.apache.org/jira/browse/JCR-3729
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 2.7.4
>            Reporter: Shashank Gupta
>             Fix For: 2.7.5
>
>         Attachments: JCR-3729.patch, JCR-3729_V1.patch
>
>
> Following optimizations can be done on S3 Datastore based on customer's/S3 engineers
feedback.
> *  Use object keys to create partitions in S3 automatically.
> *  Multi-threaded migration of binary files from FileSystem to S3 datastore
> *  Externalize S3 endpoints.
> *  Asynchronous upload file to S3
> *  Slow Startup Of Instance



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message