jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amit Jain (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3735) Efficient copying of binaries in Jackrabbit DataStores
Date Tue, 25 Feb 2014 05:33:21 GMT

    [ https://issues.apache.org/jira/browse/JCR-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911265#comment-13911265
] 

Amit Jain commented on JCR-3735:
--------------------------------

>> Hm, you mean we create a new variant of FileDataStore that doesn't do de-duplication?
OK, that's an idea.
I was thinking of enhancing the FileDataStore with a configurable flag for de-duplication,
with the default behavior being the present behavior.

>>And of course the user might decide to pass a wrapped input stream (BufferedInputStream
or similar). I don't know of a good solution for this.
Yes, this case can't be handled.

>> We can do that, but the gains will be much smaller than if we could avoid the temporary
file entirely.
Since, this requires the layers higher up to make the change, we can put in this change.
And also try to make an accompanying change which avoids creating temp files directly, at
least in Jackrabbit. 

> Efficient copying of binaries in Jackrabbit DataStores
> ------------------------------------------------------
>
>                 Key: JCR-3735
>                 URL: https://issues.apache.org/jira/browse/JCR-3735
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 2.7.4
>            Reporter: Amit Jain
>
> In the DataStore implementations an additional temporary file is created for every binary
uploaded. This step is an additional overhead when the upload process itself creates a temporary
file. 
> So, the solution proposed is to check if the input stream passed is a FileInputStream
and then use the FileChannel object associated with the input stream to copy the file.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message