Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 58DDA10324 for ; Thu, 7 Nov 2013 12:43:49 +0000 (UTC) Received: (qmail 17921 invoked by uid 500); 7 Nov 2013 12:42:49 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 17807 invoked by uid 500); 7 Nov 2013 12:42:32 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 17760 invoked by uid 99); 7 Nov 2013 12:42:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Nov 2013 12:42:19 +0000 Date: Thu, 7 Nov 2013 12:42:19 +0000 (UTC) From: "Konrad Windszus (JIRA)" To: dev@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (JCR-3293) AbstractLoginModule: get rid of trust_credentials_attribute MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JCR-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815917#comment-13815917 ] Konrad Windszus commented on JCR-3293: -------------------------------------- What is the proposed alternative then? For example if you want to support SSO? Logging in with the administrator and impersonate as the SSO user? > AbstractLoginModule: get rid of trust_credentials_attribute > ----------------------------------------------------------- > > Key: JCR-3293 > URL: https://issues.apache.org/jira/browse/JCR-3293 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core > Affects Versions: 2.4 > Reporter: angela > > based on JCR-2355 we added a very simplistic way to indicate to the login module that the given credentials have > been preauthenticated. as already stated in the original issue this poses a major security issue as it leaves the > repository access untrusted. > i would like to raise those security concern again and would therefore like to get rid of that hack in the long run. > the suggested procedure: > - deprecate the attribute (immediately) > - log a warning if it is used (immediately) > - document how to fix code that is currently relying on that attribute > - remove support altogether for the next major release -- This message was sent by Atlassian JIRA (v6.1#6144)