jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3692) MoveAtRootTest fails and is not included in test suite
Date Mon, 11 Nov 2013 15:56:21 GMT

    [ https://issues.apache.org/jira/browse/JCR-3692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819053#comment-13819053
] 

angela commented on JCR-3692:
-----------------------------

adding the extra verification actually revealed another issue present with the validation
present with Session#move, which checks if the source parent can be removed (in contrast to
the destination parent where it verifies if it can be modified). this seems wrong to me as
the method #checkRemove is otherwise called with the remove-target being passed as item to
the method.

the test should check if
- the target node can be removed
- the source parent can be modified
- the destination parent can be modified.

> MoveAtRootTest fails and is not included in test suite
> ------------------------------------------------------
>
>                 Key: JCR-3692
>                 URL: https://issues.apache.org/jira/browse/JCR-3692
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>            Reporter: Bertrand Delacretaz
>            Assignee: angela
>            Priority: Minor
>         Attachments: activate-moveatroot.patch
>
>
> The MoveAtRootTest introduced by JCR-2680 fails when executed against the current jackrabbit-core
trunk (mvn clean test -Dtest=MoveAtRootTest), with "javax.jcr.RepositoryException: Attempt
to remove/move the admin user".
> The operation that fails is Session.move("/MoveAtRootTest_A", "/MoveAtRootTest_B")
> AFAICS this is caused by the JCR-3686 changes. The same test passes on the http://svn.apache.org/repos/asf/jackrabbit/tags/2.6.4
revision.
> I'll attach a patch that includes the test in the core test suite. If there's a good
reason to forbid such a move, it should be documented and the test changed to reflect the
expected behavior.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message