Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 62A0110570 for ; Wed, 2 Oct 2013 07:48:42 +0000 (UTC) Received: (qmail 82521 invoked by uid 500); 2 Oct 2013 07:47:54 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 82426 invoked by uid 500); 2 Oct 2013 07:47:37 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 82175 invoked by uid 99); 2 Oct 2013 07:47:25 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Oct 2013 07:47:25 +0000 Date: Wed, 2 Oct 2013 07:47:25 +0000 (UTC) From: "Ard Schrijvers (JIRA)" To: dev@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (JCR-3676) Make QueryResultImpl#isAccessGranted proctected MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JCR-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783727#comment-13783727 ] Ard Schrijvers commented on JCR-3676: ------------------------------------- ps commit checked in on 'CR-3676' instead of "JCR-3676' hence not visible in this issue. See commit below Author: ard Date: Tue Oct 1 12:10:02 2013 New Revision: 1528064 URL: http://svn.apache.org/r1528064 Log: CR-3676 make isAccessGranted protected Modified: jackrabbit/branches/2.6/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/QueryResultImpl.java Modified: jackrabbit/branches/2.6/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/QueryResultImpl.java URL: http://svn.apache.org/viewvc/jackrabbit/branches/2.6/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/QueryResultImpl.java?rev=1528064&r1=1528063&r2=1528064&view=diff ============================================================================== --- jackrabbit/branches/2.6/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/QueryResultImpl.java (original) +++ jackrabbit/branches/2.6/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/QueryResultImpl.java Tue Oct 1 12:10:02 2013 @@ -373,7 +373,7 @@ public abstract class QueryResultImpl im * @throws RepositoryException if an error occurs while checking access * rights. */ - private boolean isAccessGranted(ScoreNode[] nodes) + protected boolean isAccessGranted(ScoreNode[] nodes) throws RepositoryException { for (ScoreNode node : nodes) { try { > Make QueryResultImpl#isAccessGranted proctected > ----------------------------------------------- > > Key: JCR-3676 > URL: https://issues.apache.org/jira/browse/JCR-3676 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Reporter: Ard Schrijvers > Assignee: Ard Schrijvers > Fix For: 2.6.4 > > > Because we mapped our security model to lucene queries, we'd like to override the expensive QueryResultImpl#isAccessGranted method. I will make the method protected instead of private. If someone has strong objections, please let me know > Regards Ard -- This message was sent by Atlassian JIRA (v6.1#6144)