jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3651) S3 Datastore implementation
Date Wed, 04 Sep 2013 10:19:51 GMT

    [ https://issues.apache.org/jira/browse/JCR-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757627#comment-13757627

Thomas Mueller commented on JCR-3651:


Some more comments. There are many "Java beginners" errors in the code.

Don't initialize fields to their default value (null, false,...) :

protected String config = null;

Instead, simply use:

protected String config;

In the test class hierarchy there are duplicate fields, similar to:

class TestBase {
    protected String config;
class TestExtends extends TestBase {
    protected String config;

The second field hides the field in TestBase.

Many of the Javadocs comments are low quality; they don't add any valuable information. They
should either be removed or a meaningful description should be added. Example:

+     * @param store
+     * @param homeDir
+     * @param config
+     * @throws DataStoreException
+     */
+    void init(CachingDataStore store, String homeDir, String config) throws DataStoreException;

Also, javadocs of the following type are basically no-ops and should be removed:

+    /**
+     * @inheritDoc
+     */

There are some comments "// TODO Auto-generated method stub", they should be removed.

I suggest to use an IDE such as Eclipse or IntelliJ, enable code warnings and go though that
list and fix the warnings. Also, I suggest to use Checkstyle.

> S3 Datastore implementation
> ---------------------------
>                 Key: JCR-3651
>                 URL: https://issues.apache.org/jira/browse/JCR-3651
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 2.7
>            Reporter: Shashank Gupta
>             Fix For: 2.7.1
>         Attachments: JCR-3651.patch, JCR-3651-svn.patch
> S3 Datastore provides capability to use Amazon S3 as datastore, thus leveraging all benefits
of Amazon S3 like low cost, infinite, reliable, scalable storage.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message