jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3651) S3 Datastore implementation
Date Wed, 11 Sep 2013 13:55:58 GMT

    [ https://issues.apache.org/jira/browse/JCR-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764314#comment-13764314

Thomas Mueller commented on JCR-3651:

Thanks a lot! I have a few more comments:

- The code currently doesn't use {{@Override}}
- There are some unused imports
- There is a lot of duplicate code in TestCaseBase
- CachingDataStore.addRecord: length is not used
- CachingDataStore.mkdirs can be declared static
- S3Backend.write: uploadResult is not used
- S3Backend.getKeyName can be declared static
- S3Backend.getIdentifierName can be declared static
- TestS3Ds and TestInMemDsCacheOff LOG is not used
- if (...) should use {}
- I have changed the visibility of some fields and methods
  to avoid synthetic accessor methods

I will try to commit the patch now.
> S3 Datastore implementation
> ---------------------------
>                 Key: JCR-3651
>                 URL: https://issues.apache.org/jira/browse/JCR-3651
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 2.7
>            Reporter: Shashank Gupta
>         Attachments: JCR-3651.patch, JCR-3651-svn.patch, JCR-3651-svn-updated.patch
> S3 Datastore provides capability to use Amazon S3 as datastore, thus leveraging all benefits
of Amazon S3 like low cost, infinite, reliable, scalable storage.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message