Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9307910D48 for ; Mon, 26 Aug 2013 18:04:00 +0000 (UTC) Received: (qmail 98948 invoked by uid 500); 26 Aug 2013 18:04:00 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 98352 invoked by uid 500); 26 Aug 2013 18:03:56 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 97728 invoked by uid 99); 26 Aug 2013 18:03:55 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Aug 2013 18:03:55 +0000 Date: Mon, 26 Aug 2013 18:03:55 +0000 (UTC) From: "Tobias Bocanegra (JIRA)" To: dev@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (JCR-3654) Error MembershipCache if a group node contains MV property MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JCR-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750330#comment-13750330 ] Tobias Bocanegra commented on JCR-3654: --------------------------------------- fixed in trunk with revision 1517627. > Error MembershipCache if a group node contains MV property > ---------------------------------------------------------- > > Key: JCR-3654 > URL: https://issues.apache.org/jira/browse/JCR-3654 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: security > Affects Versions: 2.2, 2.3, 2.4, 2.5, 2.6, 2.7 > Reporter: Tobias Bocanegra > Assignee: Tobias Bocanegra > > the MembershipCache.collectDeclaredMembershipFromTraversal traverses the entire /home/groups tree and analyzes all properties if they contain a reference to the authorizable node. this is very suboptimal and in case there is a multivalue, this even throws an error. > suggest: > * do an intelligent traversal instead using the TraversingItemVisitor. > * be cautious not to read MV properties unchecked. > Potential error: > com.day.crx.security.ldap.LDAPLoginModule Cause: javax.jcr.ValueFormatException: propert > y /home/groups/a/administrators/jcr:mixinTypes is a multi-valued property, so it's values can only be retrieved as an array > at org.apache.jackrabbit.core.PropertyImpl.internalGetValue(PropertyImpl.java:483) > at org.apache.jackrabbit.core.PropertyImpl.getValue(PropertyImpl.java:510) > at org.apache.jackrabbit.core.PropertyImpl.getString(PropertyImpl.java:520) > at org.apache.jackrabbit.core.security.user.MembershipCache$1.entering(MembershipCache.java:363) > at javax.jcr.util.TraversingItemVisitor.visit(TraversingItemVisitor.java:160) > at org.apache.jackrabbit.core.PropertyImpl.accept(PropertyImpl.java:904) > at javax.jcr.util.TraversingItemVisitor.visit(TraversingItemVisitor.java:187) > at org.apache.jackrabbit.core.NodeImpl.accept(NodeImpl.java:1720) > at javax.jcr.util.TraversingItemVisitor.visit(TraversingItemVisitor.java:191) > at org.apache.jackrabbit.core.NodeImpl.accept(NodeImpl.java:1720) > at javax.jcr.util.TraversingItemVisitor.visit(TraversingItemVisitor.java:191) > at org.apache.jackrabbit.core.security.user.MembershipCache.collectDeclaredMembershipFromTraversal(MembershipCache.java:374) > at org.apache.jackrabbit.core.security.user.MembershipCache.collectDeclaredMembership(MembershipCache.java:200) > at org.apache.jackrabbit.core.security.user.AuthorizableImpl.collectMembership(AuthorizableImpl.java:358) > at org.apache.jackrabbit.core.security.user.AuthorizableImpl.declaredMemberOf(AuthorizableImpl.java:89) > at org.apache.jackrabbit.core.security.user.UserImpl.declaredMemberOf(UserImpl.java:38) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira